Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp935294pxv; Thu, 1 Jul 2021 12:42:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzA1l8SEG9iKIf7vjZCD7Y3XwCm4Jwj+QL/kUEqz7fnmhprEYaQsSS02yxBiTQThG5bN5lU X-Received: by 2002:a02:cd21:: with SMTP id h1mr1291312jaq.114.1625168527378; Thu, 01 Jul 2021 12:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625168527; cv=none; d=google.com; s=arc-20160816; b=BvLydDKqhYTq5wOHKLvfZQJV2SdOaFp7uRuREEMyWC8Bo3ipQkHLpV5J+4aUdzcALA FDLQ/K1ImOYtDAu2jw4z+9DUI0PEfMS77dnIviDVtHtMumPpfbMVP51u2Eus4hT/dMkC OCFBJ6Ry0ScW9Dl8g1JDR4U69uQD842oEUdTbPYt/Hltvk1OX2J1r4Hz1yDf6iE0c2H/ kFXZZqFi3RSZdElXQ0smGWU4U6IC9G5H4JtVJ4eTzP8Pm1ZjVm7jUGUhX8zk8M6I97qX 6K3VUkdVhA7qHKvEBS+vCbGNF3qZ182B2UM7un9+7jDcB0wQNiK8rM9SYaqwWSXmE/Y8 SE9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kgry+NHhIXRto0lihG09dvKrpOIpSuRCcDkQYUAh4RI=; b=ae3pQ+92lFddVwy95vv2Ia/tsr0dyOrPt+v9KpOQkS32AqrN8KxBUzGjbk6sa2v6hy aaZXnxmd3ishfjZAWfBJGIqiB3pYYv71OCQcesYUyrQkIelWnDmQ1ZR66hhl5ej4yC+w ewRoUiN04BW9Wq0qH83O5Qf88EfHUNkCmAD4iiwZvJWvFFb5xfpuS8V52XWiffZ4hIgv ha4DXbMd4G5GU6F4DmFS6nPyvERBkSRDhb0OdgFUqIYcykdFLjLtVj65FHe0GzHReKCT PZFu5G+u7JGU0AqZZ1KZiA5LbD5sC/NwzazKVY0gB2zJiXa/CH/zO+BlCeiFMXwf7b0u kpeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aizhnnYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si733342ilt.27.2021.07.01.12.41.41; Thu, 01 Jul 2021 12:42:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aizhnnYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232971AbhGATaw (ORCPT + 99 others); Thu, 1 Jul 2021 15:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234106AbhGAT3M (ORCPT ); Thu, 1 Jul 2021 15:29:12 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD48C0613DB for ; Thu, 1 Jul 2021 12:26:41 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id h9so8555307oih.4 for ; Thu, 01 Jul 2021 12:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kgry+NHhIXRto0lihG09dvKrpOIpSuRCcDkQYUAh4RI=; b=aizhnnYOcdskMEQ6r7sUhkeD59cflOqSzk9alJZHPv3y5LbR1/JWMIX51EAoC3Q6ya T/1dJ9/FcXOXLZC9bgH1vVyLDDXla90OgKB4eygUvPEaddF7R/i311qvgRyaCIj3mH/D UU1CdRZiiz8/tnHaMJQqP7qTCNTmp+cqjQBBqCiv6j5RpkjuLeNjfCYFeR5GoHElPWhF u72S5BFduhL0HeBtjtkrN5E15Kt4cZH+d8HtNNB1CHW9w0yqkEteCl6REChwMY+rgDWj SjUs9dSJpxkkFAEP1yvxhhjyyQlyZG1BrGdyH7Ms6GzJgo0wPAryxK1ZGl+4f2W/+lIY mezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kgry+NHhIXRto0lihG09dvKrpOIpSuRCcDkQYUAh4RI=; b=Icx3GY5FRL4BFw469ipFhfUPb5u5eygxZ0wpGKhDNAvJ1FDPGjauKkYqxS9nMM6Dp3 8Ep0ucUfvHQGE1N1SZxv9WJMy2uB5g+NryhO17EBfQzzx7FuD7nS8wTfTUyXzAEOmmSW m5iQKnVXj573B0gJ5uUMm2CK1c9el7lp150DeWEpcNrxctp5pM7cuYj/Nufopz2FthE2 BCdvIDTrS/eVjp8Pwy5CShhgtiI3e5cWSrkov0RzMNVjseE9VOYayT4DpW8lrj1C5hVq zbPNAW/Pj0rEmjpjLrcf5UwOjDB47ul21f0NQb/ZWwUOeZK3OsSwVSnehIDgfXQnf8LQ xOVw== X-Gm-Message-State: AOAM531Ww5Sf+92jcbx9bwylMWYVpN1CU2HgxI2eYDkNfNFsk+1kad5f pZo2ziV/JpFog6k1Dcej3ffrMA== X-Received: by 2002:aca:d0c:: with SMTP id 12mr2441231oin.62.1625167601087; Thu, 01 Jul 2021 12:26:41 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n65sm129311ota.37.2021.07.01.12.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 12:26:40 -0700 (PDT) Date: Thu, 1 Jul 2021 14:26:38 -0500 From: Bjorn Andersson To: Ulf Hansson Cc: Dmitry Baryshkov , Andy Gross , Rob Herring , Stephen Boyd , Taniya Das , Jonathan Marek , Michael Turquette , linux-arm-msm , DTML , linux-clk , Bryan O'Donoghue , Mark Brown , Linux Kernel Mailing List Subject: Re: [PATCH 1/6] dt-bindings: clock: qcom,dispcc-sm8x50: add mmcx power domain Message-ID: References: <20210630133149.3204290-1-dmitry.baryshkov@linaro.org> <20210630133149.3204290-2-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 01 Jul 11:58 CDT 2021, Ulf Hansson wrote: > On Thu, 1 Jul 2021 at 18:39, Dmitry Baryshkov > wrote: > > > > On Thu, 1 Jul 2021 at 19:17, Ulf Hansson wrote: > > > > > > On Wed, 30 Jun 2021 at 15:31, Dmitry Baryshkov > > > wrote: > > > > > > > > On sm8250 dispcc requires MMCX power domain to be powered up before > > > > clock controller's registers become available. For now sm8250 was using > > > > external regulator driven by the power domain to describe this > > > > relationship. Switch into specifying power-domain and required opp-state > > > > directly. > > > > > > > > Signed-off-by: Dmitry Baryshkov > > > > --- > > > > .../bindings/clock/qcom,dispcc-sm8x50.yaml | 19 +++++++++++++++++++ > > > > 1 file changed, 19 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > > > index 0cdf53f41f84..48d86fb34fa7 100644 > > > > --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > > > +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > > > @@ -55,6 +55,16 @@ properties: > > > > reg: > > > > maxItems: 1 > > > > > > > > + power-domains: > > > > + description: > > > > + A phandle and PM domain specifier for the MMCX power domain. > > > > + maxItems: 1 > > > > + > > > > > > Should you perhaps state that this is a parent domain? Or it isn't? > > > > > > Related to this and because this is a power domain provider, you > > > should probably reference the common power-domain bindings somewhere > > > here. Along the lines of this: > > > > > > - $ref: power-domain.yaml# > > > > > > As an example, you could have a look at > > > Documentation/devicetree/bindings/power/pd-samsung.yaml. > > > > I'll take a look. > > > > > > > > > + required-opps: > > > > + description: > > > > + Performance state to use for MMCX to enable register access. > > > > + maxItems: 1 > > > > > > According to the previous discussions, I was under the assumption that > > > this property belongs to a consumer node rather than in the provider > > > node, no? > > > > It is both a consumer and a provider. It consumes SM8250_MMCX from > > rpmhpd and provides MMSC_GDSC. > > That sounds a bit weird to me. > dispcc is a hardware block powered by MMCX, so it is a consumer of it and needs to control MMCX. > In my view and per the common power domain bindings (as pointed to > above): If a power domain provider is a consumer of another power > domain, that per definition means that there is a parent domain > specified. > And in addition to needing MMCX to access the dispcc, the exposed power-domain "MDSS_GDSC" is powered by the same MMCX and as such MDSS_GDSC should be a subdomain of MMCX. But what I was trying to say yesterday is that the power-domain property should be sufficient and that we shouldn't need to drive MMCX to a particular performance_state in order to access the registers. Then as clients make votes on clock rates that requires higher performance_state, they would describe this in their opp-tables etc. But without any performance_state requests, pd->corner will in rpmhpd_power_on() be 0 and as such powering on the power-domain won't actually do anything. Similarly dev_pm_genpd_set_performance_state(dev, 0) on an active power-domain from rpmhpd will turn it off. So the reason why Dmitry is adding the required-opps to the binding is to get rpmhpd to actually tell the hardware to turn on the power domain. And I don't think this is in accordance with the framework's expectations. Regards, Bjorn