Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp935599pxv; Thu, 1 Jul 2021 12:42:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztf0tgZe8q1ahMMycNiHbkOsFJMrCjpqOpdP8Ch32R4CU2g9jioxBFyboZj4h/DzlKbe+F X-Received: by 2002:a92:9502:: with SMTP id y2mr748216ilh.1.1625168557922; Thu, 01 Jul 2021 12:42:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625168557; cv=none; d=google.com; s=arc-20160816; b=m6T3krI5T9uuBdNu9fO9gl3KyKPQhEIK9/PyGaiMYpEkK17CcsiwLs5ZPpPwGfv0CL eiuitt5UY1+y4ARtAC2knkF4KdRf/ZukGenao05HBrAfK88IkB708pvKRZ7hefN4WlR3 OLkY805y7r8ps/rN1x7IAl4qI0YVYP3YelSWG/1ovc0O3NK6LLFK+z+guRvpbEg1CiM8 t7bBu3LNUSCwvaAofCYjmrNOXJLHxIx2GAFPkiY2gCrHDmQcweYaImP9y7EEtPhOph4f Y+/HGTMu9Bgg+ZOjLhW+z9FAe/b4XA4s091touI54WRjSkYmzguZ1UZh1c+vD01vjVn2 D+0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version; bh=6ySghOdTECgYAT/QKbqdh9/NORKkvMoBrOegkSPn66Q=; b=olghBxCvmMuYoA8KLQx8cGSYLW84JprpjrHhVaayXWUFFxgyb/1j/jFFHegNzdUjOB TZZ007YbT69H5XVdUNqfLZ2+NgWIIrdLk0lcgoUyVHUh9RazRXjVLX1FQwPqk9aNUHac wzutUfB0dQSvn4p7gK0Mo9POk/fHis/XHvMiAk7+381qBbXjbdeYuK853lK+8s47jvu4 gGd2OPsVO7I4gTRDVmpY8iw9iciSJByCt5ctXCauM+Vu32v7TmHcd3ZjY0lK7a5yb+c8 za7CIK7OyVNCEZR7GUOEwLidhfoI2/UgzPhxMJ/agMpbeX6E1fxN0h2C9WqTO2USRs0A TFag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si955351jad.115.2021.07.01.12.42.25; Thu, 01 Jul 2021 12:42:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231842AbhGATiC (ORCPT + 99 others); Thu, 1 Jul 2021 15:38:02 -0400 Received: from smtprelay0132.hostedemail.com ([216.40.44.132]:39464 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229894AbhGATiC (ORCPT ); Thu, 1 Jul 2021 15:38:02 -0400 Received: from omf06.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id C82ED182CF666; Thu, 1 Jul 2021 19:35:30 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id 6CD962448B8; Thu, 1 Jul 2021 19:35:30 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 01 Jul 2021 12:35:29 -0700 From: Joe Perches To: Steven Rostedt Cc: Paul Burton , Joel Fernandes , linux-kernel@vger.kernel.org, Ingo Molnar , stable@vger.kernel.org Subject: Re: [PATCH 1/2] tracing: Simplify & fix saved_tgids logic In-Reply-To: <20210701142624.44bb4dde@oasis.local.home> References: <20210630003406.4013668-1-paulburton@google.com> <20210701140754.5847a50f@oasis.local.home> <20210701142624.44bb4dde@oasis.local.home> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <51babd56c2fe53ba011152700a546151@perches.com> X-Sender: joe@perches.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.90 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 6CD962448B8 X-Stat-Signature: 8b1988hbxa8dkbeondchxrn7teat51ri X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19G+PKuYMGNpgor/GEopWJcjhvhoKlY1NU= X-HE-Tag: 1625168130-156347 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-01 11:26, Steven Rostedt wrote: > [ Added Joe Perches ] > > On Thu, 1 Jul 2021 11:12:54 -0700 > Paul Burton wrote: > >> > not to mention, we don't >> > use '//' comments in the kernel, so that would have to be changed. >> >> D'oh! Apparently a year away from the kernel melted my internal style >> checker. Interestingly though, checkpatch didn't complain about this >> as >> I would have expected... > > Joe, should the above be added to checkpatch? > > I do understand that there are a few cases it's acceptable. Like for > SPDX headers. C99 comments are allowed since about 5 years ago. And if you really want there's a checkpatch option to disable them. https://lore.kernel.org/patchwork/patch/1031132/