Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 1 Jul 2021 15:51:00 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Joe Perches <joe@perches.com>
Cc:     Paul Burton <paulburton@google.com>,
        Joel Fernandes <joelaf@google.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/2] tracing: Simplify & fix saved_tgids logic
Message-ID: <20210701155100.3f29ddfb@oasis.local.home>
In-Reply-To: <51babd56c2fe53ba011152700a546151@perches.com>
References: <20210630003406.4013668-1-paulburton@google.com>
        <CAJWu+ooRQ6hFtaA4tr3BNs9Btss1yan8taua=VMWMopGmEVhSA@mail.gmail.com>
        <YN38D3dg0fLzL0Ia@google.com>
        <20210701140754.5847a50f@oasis.local.home>
        <YN4Fpl+dhijItkUP@google.com>
        <20210701142624.44bb4dde@oasis.local.home>
        <51babd56c2fe53ba011152700a546151@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 01 Jul 2021 12:35:29 -0700
Joe Perches <joe@perches.com> wrote:

> C99 comments are allowed since about 5 years ago.

Really, I thought Linus hated them. Personally, I find them rather ugly
myself. The only user of them I see in the kernel/ directory appears to
be for RCU. But Paul's on the C/C++ committee, so perhaps he favors them.

The net/ directory doesn't have any, except perhaps to comment out code
(which I sometimes use it for that too).

The block/, arch/x86/ directories don't have them either.

I wouldn't go and change checkpatch, but I still rather avoid them,
especially for multi line comments.

 /*
  * When it comes to multi line comments I prefer using something
  * that denotes a start and an end to the comment, as it makes it
  * look like a nice clip of information.
  */

Instead of:

  // When it comes to multi line comments I prefer using something
  // that denotes a start and an end to the comment, as it makes it
  // look like a nice clip of information.

Which just looks like noise. But hey, maybe that's just me because I
find "*" as a sign of information and '//' something to ignore. ;-)

-- Steve