Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp950353pxv; Thu, 1 Jul 2021 13:07:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysKZqPPLivXjEJu2xcRmlQv+z54Dv09iLQfkg2ejefGQNE6ke9G3VRcDmPtB2wV9nRIL7c X-Received: by 2002:a5d:80cf:: with SMTP id h15mr911497ior.30.1625170027643; Thu, 01 Jul 2021 13:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625170027; cv=none; d=google.com; s=arc-20160816; b=J0okFeFijOm1cFLhbMblk2+M2hRJ7iE8fsOdEVAf8egSvGwR2tkFHvtCYBxVJl+mNU PsSnBRLUehLe8CUj8W0lrLFDLYvfa9E5Mt9bAq2/8CuLc9vWyahDFm3XCJ9VT4Iql2m1 uD7w1vd30sKPfLRJfgLh+Q7AwdR5D+s8QcS5svawFw7fFLiTuO9JyErUDF2Lx2f8BhtT 8OWiMgbq29OJ0otZTV0jWNDS1744efZnSrVw/DDsSoUkbNFykzJxu23oiAFGwae5KdaL 6aNAFJEGaS4qhKIbsNoDM55iT2qm38kGsCJHv8eZW2jHWxAVrgmdhXDehxclqdR//9Qf lvYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:jabber-id:message-id:subject:cc:to:from:date; bh=wR/mwb9vmOuCu/5IxYCDmTKuzJ2KfMmdp/brizBCJOo=; b=ewJQbFH02GQ/M19yO3ow3wBoKjBvHf8HZvMrUbd10izzbG2vmhdtuOL8QcgdfcP7eL fzuI7PjVJfhV5uxMBnVhTdpSeNV8kJEaZlJW/Qr4lOaDGew8a6N7XQWxxYwToDHI95Ea uA2FdO3IAAAAVoJ878Qfu5AcqBNGRDsrYRbS+fLaCd6KuvszFs6mq+X0+vS19YaP6vjR Q1EMedH1E9auakgl6MwM3Io5IgG4vGrLwZg2Ifnc2UdmqO2kItaBjSShOFvwffNsKAgK HzYLEZTQd2nIl0ZclubypFCj/xKho2OHpX5ZdQa2waNc99JiHovSTLfjhgfROGRUcIGd sEDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l15si885009iok.34.2021.07.01.13.06.55; Thu, 01 Jul 2021 13:07:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232637AbhGAUHo (ORCPT + 99 others); Thu, 1 Jul 2021 16:07:44 -0400 Received: from 82-65-109-163.subs.proxad.net ([82.65.109.163]:44740 "EHLO luna.linkmauve.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbhGAUHl (ORCPT ); Thu, 1 Jul 2021 16:07:41 -0400 X-Greylist: delayed 487 seconds by postgrey-1.27 at vger.kernel.org; Thu, 01 Jul 2021 16:07:40 EDT Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 06CA9F40443; Thu, 1 Jul 2021 21:56:55 +0200 (CEST) Date: Thu, 1 Jul 2021 21:56:55 +0200 From: Emmanuel Gil Peyrot To: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= Cc: Emmanuel Gil Peyrot , Srinivas Kandagatla , linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, Ash Logan , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] powerpc: wii.dts: Expose the OTP on this platform Message-ID: <20210701195655.knbcikdga57a7epx@luna> Jabber-ID: linkmauve@linkmauve.fr References: <20210519095044.4109-1-linkmauve@linkmauve.fr> <20210519095044.4109-4-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5xpqystiypqfkjaq" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5xpqystiypqfkjaq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neusch=C3=A4fer wrote: > On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote: > > This can be used by the newly-added nintendo-otp nvmem module. > >=20 > > Signed-off-by: Emmanuel Gil Peyrot > > --- > > arch/powerpc/boot/dts/wii.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > >=20 > > diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.= dts > > index aaa381da1906..7837c4a3f09c 100644 > > --- a/arch/powerpc/boot/dts/wii.dts > > +++ b/arch/powerpc/boot/dts/wii.dts > > @@ -219,6 +219,11 @@ control@d800100 { > > reg =3D <0x0d800100 0x300>; > > }; > > =20 > > + otp@d8001ec { > > + compatible =3D "nintendo,hollywood-otp"; > > + reg =3D <0x0d8001ec 0x8>; >=20 > The OTP registers overlap with the previous node, control@d800100. > Not sure what's the best way to structure the devicetree in this case, > maybe something roughly like the following (untested, unverified): [snip] I couldn=E2=80=99t get this to work, but additionally it looks like it shou= ld start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given https://wiibrew.org/wiki/Hardware/Hollywood_Registers Would it make sense, for the time being, to reduce the size of this control@d800100 device to the single register currently being used by arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the system) and leave the refactor of restart + OTP + PIC + GPIO for a future series? Thanks, --=20 Emmanuel Gil Peyrot --5xpqystiypqfkjaq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEjrVT1SzTln43kCLJOWgfYkb2LpAFAmDeHgQACgkQOWgfYkb2 LpBR1wgAo8/AW14uyzt1Z177k6xWkLqlqUXPSqvRzsrEbtn4t/IlewtlPOrwBntP v9cBf82hjFyNeKZMOGD/3Hka8bXBlsqrcVZUEPxUYuty6f+qsQ96AIYeVdN+S4It 8wquNDtGA3VIJY6xxD+sDE+GplNH5WeUO/dhLqXxlSDi52fSyUK/mc6DIcXHC+q8 f+RW6VDgVVVrJdhofhvHoO/2g0BwKNWOmfyv70RXUvZq+mT6lI3liEkEeAm8TyxP 4logyZ9vZYg/LhjceqHTnppXl5XyBPeOznBVbygdeJh7igBfRsh6Pz2ISgYeS51N YhJjzLcGv44IlTttJz1GkRzIwHj0wg== =zJte -----END PGP SIGNATURE----- --5xpqystiypqfkjaq--