Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp985976pxv; Thu, 1 Jul 2021 14:07:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7L2QtTWAFpss7503ht4/UQLOCJ5eEeQucGXKdA/YPAigVVJqPiR3pttb7pqIWnfKV8yOk X-Received: by 2002:a92:9509:: with SMTP id y9mr1028845ilh.18.1625173634703; Thu, 01 Jul 2021 14:07:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625173634; cv=none; d=google.com; s=arc-20160816; b=W8hy8v5XtPBx0jxmtiibdqnGhs+Yl5/XpRikTcxqnp18fyXyvzOvXubLmg3QrcdBLb 4ML7h5Zge3nvx2Ui26znGit/rAuk+BU4nwIG8AoipoAOc81zW6aADFJUgrbJ0PZTa/3m dErHK4V/gzPT+4TlGnfT0ebaB0LF4ywUOACVBs7EgKp9Z6+osbATJlqpXHRkEqM6BPsY 61KZUFnnrW0Cp5Cv7VvwgdyUdlrivzYkj/Pu1+bBjkXcspP7VMyV3djyf/0vzAUKvZq8 P25xtU7w7KxmRKFHgDms5qS7D+mMG8dzz3AowbgRftzXchlM99H0z89rVpvQzQ0dp2O4 +QzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EcCDAONYSvxWhrnFajQ4MKasGNW9IM2wqSHF8u7KuC4=; b=yfDeabiWoZLP3IqgTSjZ82cExdWA5jhlD6qFxc0iB60XjsG/Hm118SN8tNBxZoFLOh i6zyNyQRvgF3OqTKs7/frgNDbNBdDlQEauVy+gU4kFA/eOq4Wh8kXnP+JptFceoCiVCB +4j4/ObfVPC1lXPlSgDb+k5Q+lz+LWi480/P2CfzY7qjGE2KKV/fopzhbBJE543lia3T nO2MPu7L16O0FiT/pyQdaf+eYC/bFe4+ZDC87H90gdXpjI7eGMGKTIAPFOWh4tgbwedc u8oT4EAcL9zH6UyB2M09wYDKAZ5HGaUP29tuin7N2FAGuxwuCeBkDCrl64ymf2qDzzqe uWRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si1033225iov.21.2021.07.01.14.07.03; Thu, 01 Jul 2021 14:07:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234254AbhGAUn6 (ORCPT + 99 others); Thu, 1 Jul 2021 16:43:58 -0400 Received: from out02.smtpout.orange.fr ([193.252.22.211]:36456 "EHLO out.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234145AbhGAUn5 (ORCPT ); Thu, 1 Jul 2021 16:43:57 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d15 with ME id PwhP2500U21Fzsu03whQxr; Thu, 01 Jul 2021 22:41:24 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 01 Jul 2021 22:41:24 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: csully@google.com, sagis@google.com, jonolson@google.com, davem@davemloft.net, kuba@kernel.org, awogbemila@google.com, willemb@google.com, yangchun@google.com, bcf@google.com, kuozhao@google.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH net-next v2] gve: Simplify code and axe the use of a deprecated API Date: Thu, 1 Jul 2021 22:41:19 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The wrappers in include/linux/pci-dma-compat.h should go away. Replace 'pci_set_dma_mask/pci_set_consistent_dma_mask' by an equivalent and less verbose 'dma_set_mask_and_coherent()' call. Signed-off-by: Christophe JAILLET --- If needed, see post from Christoph Hellwig on the kernel-janitors ML: https://marc.info/?l=kernel-janitors&m=158745678307186&w=4 v2: Unchanged This patch was previously 3/3 of a serie --- drivers/net/ethernet/google/gve/gve_main.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index c03984b26db4..099a2bc5ae67 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -1477,19 +1477,12 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent) pci_set_master(pdev); - err = pci_set_dma_mask(pdev, DMA_BIT_MASK(64)); + err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (err) { dev_err(&pdev->dev, "Failed to set dma mask: err=%d\n", err); goto abort_with_pci_region; } - err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)); - if (err) { - dev_err(&pdev->dev, - "Failed to set consistent dma mask: err=%d\n", err); - goto abort_with_pci_region; - } - reg_bar = pci_iomap(pdev, GVE_REGISTER_BAR, 0); if (!reg_bar) { dev_err(&pdev->dev, "Failed to map pci bar!\n"); -- 2.30.2