Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966198AbWKNQly (ORCPT ); Tue, 14 Nov 2006 11:41:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966200AbWKNQly (ORCPT ); Tue, 14 Nov 2006 11:41:54 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:7363 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S966198AbWKNQlx (ORCPT ); Tue, 14 Nov 2006 11:41:53 -0500 Message-ID: <4559F1CE.9040805@garzik.org> Date: Tue, 14 Nov 2006 11:41:50 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: Mark Lord CC: Andrew Morton , Linus Torvalds , linux-ide@vger.kernel.org, LKML Subject: Re: [git patches] libata fixes References: <20061114150454.GA11900@havoc.gtf.org> <4559EFB2.1000809@rtr.ca> In-Reply-To: <4559EFB2.1000809@rtr.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.7 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 16 Mark Lord wrote: > Any time we return 0 from queuecommand, the SCSI mid-layer expects us > to also take care of invoking the done() function. Where does this now > happen for this case (err_mem) ??? It _already_ happened in the error path of ata_scsi_qc_new(), which is why this is a double-completion bug fix. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/