Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1241087pxv; Thu, 1 Jul 2021 21:58:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhi319BtL6I61SEgdi5Hww91/MCvh3dBX5mUdyOdKtvUmLnplKpOQCBGf1da+pILVUg8s8 X-Received: by 2002:a17:907:7b93:: with SMTP id ne19mr3560864ejc.56.1625201901685; Thu, 01 Jul 2021 21:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625201901; cv=none; d=google.com; s=arc-20160816; b=ljLse4102WdM7byvo2RPjtM/uMKrioKDAgYx5P7vgO5gdYLo6S3vGZMh2YZC7TQJcX 2DEuaSjKxccJAfMSQWmTtbP6xgsh+jOdG22148koL+qBTKE/FLm2E/MGbnSPvsgoLclz 3ecSFypPE5pvaGQLn2DsWg8wfg6MaRzoLKFPOBQ2eWWYywuShxl0526dACyb7he8ApbE JC0mGsbZ+vJXWW+qAO+iJFomViqJUkaWrcnRTTj/jF2zFlc2/rgzyobBaLqauJLVMzIi 7qTlqKdbvEga5TLMkR2eK7DGSi2hZidF3QZ7NwoTLXdUi6TqJkZJWORlHQeO9E8nvM06 qX3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qqSo2EHKnteCkmvIob7W7h8j2bBButMHNumXS1B2l4o=; b=J92i1krFZLftcye0O8+IQl2ncHTclTG2643QtyGiR14o2uKMVE8le6HoaOW/CpRmkL 3xQxaHB6i3mFFfvySeuszAie+77Acl4Chyx4NgFQu1j00Ar78ibHK6VE9xd+8o0IyMfK BKUYubN2UllTEecBWqDBsITQbFHhU00f/mqbTg9pXHpz1uXFyfi3jhpFFCz1Cd3Wdk0N H///FcjxYQP4xL5NPaDKwJ3SXZ8gu9SESB1H4ap6qi6Rnm6W45XaGhXD+EcYrHwqje+1 vlCjg3wrxVEdaMkDRTmhRrmuASpLZHofll5OoTSINhb5cSu13BQgHzPgpw87BGsEmajw BBZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=THUTh9lL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc23si2211578ejc.167.2021.07.01.21.57.56; Thu, 01 Jul 2021 21:58:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=THUTh9lL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232852AbhGBE7M (ORCPT + 99 others); Fri, 2 Jul 2021 00:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233691AbhGBE7L (ORCPT ); Fri, 2 Jul 2021 00:59:11 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A99BDC061764 for ; Thu, 1 Jul 2021 21:56:36 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id w15so8415793pgk.13 for ; Thu, 01 Jul 2021 21:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qqSo2EHKnteCkmvIob7W7h8j2bBButMHNumXS1B2l4o=; b=THUTh9lL4gLgfoWs25q+r7nEzcReUOTkjZ6PBQSvLYhT5h22qQghqFKTbnb+SueClW yzFZUuYKHvmbk60MxqoXkPEIZT7QKSU230n1xDMIOEwPaorDYxvR+1FO6c9gXmnUAEyd jRmw9Ho2/f6zYuDYpi6/dqnwUEhzU5C9ovYEp1pvzM/GkwAC5SJQdnZMiT9DQsTp3we/ sIht4/YeX7Sq2U/klwO/Men0mMiCPsDJsV+ip84CFwlRVcNtk1HMWKNMqPPCxaTt42f8 Ts26/9nOMSVMKIGqnJ4Kejd/m3y2N8FnH+a2Kij8aGj64AQIdpA7vu2IusgPFP7lMtgD GrGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qqSo2EHKnteCkmvIob7W7h8j2bBButMHNumXS1B2l4o=; b=URMc5ZZq4XwIYg0pAp9uMahHakjRu58AyJRIWtCzzZDgfE7Bpz40/mbMuh7mtBbBzs fkrZm7YLvmWWFQm954s7e2JEi1rElbVWJM/EugH58M5jqWf4UJtBU1Ll9VbIpYJP8eDs L4yGMa8YPnkRiMHblXCg1yTe/3X2ptL7fmqPiF3olNzNJq7ZSFJCHmEHzbCxgYkyM2Ln uFfobAK91s9T0h1XMii7UAy8/nFvS5R5Ncj7tF/AlXXABRgZYR/jhKmDJnotF2NlT911 D+c4iRvJhnf0NIxHDg1VBblnHfimD4sxum8CNu027AyTM1I4S0k8S+SdUFfUczf5MS/+ YWAw== X-Gm-Message-State: AOAM530dbZbUkTbo3y42h7qwo6pfZ6/Kh1mb/Oyn23hpoIElNlagRtnm nrjqoSPWTP8cqzn0x/r168b0/A== X-Received: by 2002:aa7:96cf:0:b029:30f:d1e8:9264 with SMTP id h15-20020aa796cf0000b029030fd1e89264mr3262408pfq.33.1625201796138; Thu, 01 Jul 2021 21:56:36 -0700 (PDT) Received: from localhost ([106.201.108.2]) by smtp.gmail.com with ESMTPSA id w6sm1824644pgh.56.2021.07.01.21.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 21:56:35 -0700 (PDT) Date: Fri, 2 Jul 2021 10:26:33 +0530 From: Viresh Kumar To: Jie Deng Cc: linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, wsa@kernel.org, wsa+renesas@sang-engineering.com, mst@redhat.com, arnd@arndb.de, jasowang@redhat.com, andriy.shevchenko@linux.intel.com, yu1.wang@intel.com, shuo.a.liu@intel.com, conghui.chen@intel.com, stefanha@redhat.com Subject: Re: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver Message-ID: <20210702045633.gblpud7wcffd5kyj@vireshk-i7> References: <510c876952efa693339ab0d6cc78ba7be9ef6897.1625104206.git.jie.deng@intel.com> <20210701040436.p7kega6rzeqz5tlm@vireshk-i7> <20210701061846.7u4zorimzpmb66v7@vireshk-i7> <34092cb2-03f9-231d-8769-4e45ed51c30f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34092cb2-03f9-231d-8769-4e45ed51c30f@intel.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-07-21, 11:36, Jie Deng wrote: > OK. Let's add the following two lines to make sure that msg_buf is only > sent when the msgs len is not zero. And backend judges whether it is > a zero-length request by checking the number of elements received. > > ?+ if (msgs[i].len) { > ?????????? reqs[i].buf = i2c_get_dma_safe_msg_buf(&msgs[i], 1); > ?????????? if (!reqs[i].buf) > ?????????????????? break; > > ????????? sg_init_one(&msg_buf, reqs[i].buf, msgs[i].len); > > ????????? if (msgs[i].flags & I2C_M_RD) > ????????????????? sgs[outcnt + incnt++] = &msg_buf; > ????????? else > ????????????????? sgs[outcnt++] = &msg_buf; > +} Perfect. Thanks. -- viresh