Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Jul 2021 10:26:28 +0200 (CEST)
From:   Miroslav Benes <mbenes@suse.cz>
To:     gushengxian <gushengxian507419@gmail.com>
cc:     jpoimboe@redhat.com, peterz@infradead.org,
        linux-kernel@vger.kernel.org, gushengxian <gushengxian@yulong.com>
Subject: Re: [PATCH] objtool: avoid Memory leak: orig_alt_group
In-Reply-To: <20210702031327.559429-1-gushengxian507419@gmail.com>
Message-ID: <alpine.LSU.2.21.2107021021510.29699@pobox.suse.cz>
References: <20210702031327.559429-1-gushengxian507419@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi,

On Thu, 1 Jul 2021, gushengxian wrote:

> From: gushengxian <gushengxian@yulong.com>
> 
> free(orig_alt_group) should be added in order to avoid memery leak.
> Reported by cppcheck.
> 
> Signed-off-by: gushengxian <gushengxian@yulong.com>

It is not necessary. Objtool would exit immediately in case of this error 
and we do not handle the allocations in such cases. 

> ---
>  tools/objtool/check.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index e5947fbb9e7a..deb48b1bc16d 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -1097,6 +1097,7 @@ static int handle_group_alt(struct objtool_file *file,
>  				     sizeof(struct cfi_state *));
>  	if (!orig_alt_group->cfi) {
>  		WARN("calloc failed");
> +		free(orig_alt_group);
>  		return -1;
>  	}

There are more sites like this in the code. For example there is one a 
couple of lines later in the same function. It is fine.

Regards
Miroslav