Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Jul 2021 10:27:51 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Stefan =?utf-8?B?QnLDvG5z?= <stefan.bruens@rwth-aachen.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Daniele Palmas <dnlplm@gmail.com>,
        =?utf-8?B?QmrDuHJu?= Mork <bjorn@mork.no>
Subject: Re: [PATCH v2] USB: serial: qcserial: Support for SDX55 based Sierra
 Wireless 5G modules
Message-ID: <YN7OBzmcsidWIG0F@hovoldconsulting.com>
References: <20210611134507.8780-1-stefan.bruens@rwth-aachen.de>
 <20210611135842.14415-1-stefan.bruens@rwth-aachen.de>
 <YNQ0O0vhtpStp0n/@hovoldconsulting.com>
 <3614092.7mX7SIBJgt@pebbles>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="+fSrOke19xwIognt"
Content-Disposition: inline
In-Reply-To: <3614092.7mX7SIBJgt@pebbles>
Precedence: bulk


--+fSrOke19xwIognt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 01, 2021 at 06:41:26PM +0200, Stefan Br=C3=BCns wrote:
> On Donnerstag, 24. Juni 2021 09:28:59 CEST Johan Hovold wrote:
> > [ +CC: Daniele and Bj=C3=B8rn ]
> >=20
> > On Fri, Jun 11, 2021 at 03:58:41PM +0200, Stefan Br=C3=BCns wrote:
> > > The devices exposes two different interface compositions:
> > > - QDL mode, single interface
> > > - MBIM mode, MBIM class compliant plus AT/DM(/ADB)
> > >=20
> > > Current firmware versions (up to 01.07.19) do not expose an NMEA port.
> >=20
> > We already have at least one SDX55 based modem (FN980) supported by the
> > option driver. Any particular reason why you chose to add it to qcserial
> > instead of option?
> >=20
> Support for qualcomm based modems are spread over option and qcserial. Al=
l=20
> other Sierra devices are supported by qcserial.

Ok, but we may still end up adding this one to option if matching on the
interface protocol works.

> > Note that the FN980 also needs the ZLP flag set in QDL (flashing) mode,
> > I'd assume this one needs it too.
>=20
> It depends if you implement the Firehose protocol in accordance to the=20
> specification or not. 80-NG319-1 (Firehose specification) explicitly stat=
es to=20
> pad any XML command packet which is an exact multiple of 512 bytes with a=
n=20
> extra newline or other whitespace character.

Thanks for the details. If you're referring to the device-side
implementation it seems a bit fragile to not just set the ZLP flag since
apparently there are some non-standard implementations out there. But
sure, we can do that later if needed.

Johan

--+fSrOke19xwIognt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQHbPq+cpGvN/peuzMLxc3C7H1lCAUCYN7OAwAKCRALxc3C7H1l
CPH7AP949REvyDQL0GzQ/Iu/PBYxRIjegY+tX1YWWlsgut4yOgD9FJiHMoJ6P+lm
l1CqjIUHAzuTd3+YHA7gtM+Mbiog2Ak=
=6cXq
-----END PGP SIGNATURE-----

--+fSrOke19xwIognt--