Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1362205pxv; Fri, 2 Jul 2021 01:45:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKdzgmRCz076Xi3/zl15x/g+nppm0R8R3xruZTOTw5x4OWKPJ/gvCcYvjfyYee90fjE9bq X-Received: by 2002:a17:907:96a0:: with SMTP id hd32mr4150943ejc.198.1625215519166; Fri, 02 Jul 2021 01:45:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625215519; cv=none; d=google.com; s=arc-20160816; b=tKamxLjItBYRWYk/SXlWSdGGpydIR1fTxlHU0TgpxwJk2RsEr0g6P2wxYC8hBM9T3s gd2ts9Tg+TK6ycnzrr6tASLPjv3djRKNTX0fjlh3T+6jI9/6nkJKIkECrvOJo698nmEX UngFUYUhnGKUy8yIMVtHw1G9UI9t6FnDuhmcaZOVtLduGa5pN/YNZiENMjCIzW7id3Eu WGkNMjvb9DsppHMMXafSeLIg5q4niI5J4ZrGzq91uY5s8qCfHFCP1vmZVeU1pFTpqfa6 yu67TEoGOLfz/Bu0gWr1FbxJhF1xhKEkJsyCkEM04de3q2zpm9vbWRF6w1uJtbGaIXRB EtxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=w3yBGSGoQ8cNaUpst5+zJFm90DXtuz3EZYf+rk4KsIk=; b=LljxEDVnBxMcCY+/Qo8hU05/4uQRSJvark2muk777+SJdZUAtzEnT9ORX6jRJ8R0so v0URlBzg/1tNgMCfj2JYPPXO80MPmH5x4Ew3nFRLu6oTi7lJoI8ANe6ww0XpfJMcOPku yUPeF0Z5hFo12DKRxiAPolbl25d0EyhlEh0SLcF/WB2zduaLRZtQX2O8TyW6rOHNz9Wa sSmFM6NkiYPbqzgYjsLkoCCqFUlM8pN5miMMX4GsmMc1i1YrwIBJqyZ7UwMYyyMaE1NZ UIS+xlzUugf0uOxrhnXND/nMC/VAtXq3MmfXa1T1xiw3027LbdxmhXiSArfgsUOCBUZH hssw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=NyDjWLdw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si3018651ejc.164.2021.07.02.01.44.55; Fri, 02 Jul 2021 01:45:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=NyDjWLdw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230492AbhGBIow (ORCPT + 99 others); Fri, 2 Jul 2021 04:44:52 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:54380 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbhGBIow (ORCPT ); Fri, 2 Jul 2021 04:44:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1625215340; h=Content-Type: MIME-Version: Message-ID: Date: References: In-Reply-To: Subject: Cc: To: From: Sender; bh=w3yBGSGoQ8cNaUpst5+zJFm90DXtuz3EZYf+rk4KsIk=; b=NyDjWLdwAASsDx/hDZRACr/ldxJJknH8aGobKGftAJgDPT6yLAH039TAp5dYO1LRcejL1uLO 3SSDxzP/D0WwrrwP/o3HWAqHpwW6+SvNX1sBDDat46M6hdfZGlzHv7u63Z5cAEIimKM/BF0m uRQCCIBfsbf4LOsJfL17PpuG84I= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 60ded15eec0b18a7455b8bea (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 02 Jul 2021 08:42:06 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 570D9C4323A; Fri, 2 Jul 2021 08:42:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6DB36C433D3; Fri, 2 Jul 2021 08:42:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6DB36C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: chris.chiu@canonical.com Cc: Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org, code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtl8xxxu: disable interrupt_in transfer for 8188cu and 8192cu In-Reply-To: <20210701163354.118403-1-chris.chiu@canonical.com> (chris chiu's message of "Fri, 2 Jul 2021 00:33:54 +0800") References: <20210701163354.118403-1-chris.chiu@canonical.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Fri, 02 Jul 2021 11:41:58 +0300 Message-ID: <87v95thzu1.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chris.chiu@canonical.com writes: > From: Chris Chiu > > There will be crazy numbers of interrupts triggered by 8188cu and > 8192cu module, around 8000~10000 interrupts per second, on the usb > host controller. Compare with the vendor driver source code, it's > mapping to the configuration CONFIG_USB_INTERRUPT_IN_PIPE and it is > disabled by default. > > Since the interrupt transfer is neither used for TX/RX nor H2C > commands. Disable it to avoid the confusing interrupts for the > 8188cu and 8192cu module which I only have for verification. The last paragraph is not entirely clear for me, can you elaborate it more? What do you mean with "confusing interrupts"? And is this fixing an actual user visible bug or are you just reducing the number of interrupts? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches