Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966263AbWKNS3c (ORCPT ); Tue, 14 Nov 2006 13:29:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966261AbWKNS3c (ORCPT ); Tue, 14 Nov 2006 13:29:32 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:11679 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S966260AbWKNS3b (ORCPT ); Tue, 14 Nov 2006 13:29:31 -0500 Message-ID: <455A0B03.1080907@us.ibm.com> Date: Tue, 14 Nov 2006 10:29:23 -0800 From: "Darrick J. Wong" Reply-To: "Darrick J. Wong" Organization: IBM LTC User-Agent: Thunderbird 1.5.0.7 (X11/20060918) MIME-Version: 1.0 To: linux-scsi , Linux Kernel Mailing List CC: Alexis Bruemmer Subject: [PATCH] sas_ata: don't copy aic94xx's sactive to ata_port X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 29 Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it no longer makes any sense to copy the sactive field in the STP response to ata_port->sactive, as that will confuse libata. Also, libata seems to be capable of managing sactive on its own. The attached patch gets rid of one of the causes of the BUG messages in ata_qc_new, and should apply against jejb's aic94xx-sas git tree. -- Signed-off-by: Darrick J. Wong diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index ca49d3e..9580d81 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -108,7 +108,6 @@ static void sas_ata_task_done(struct sas dev->sata_dev.sstatus = resp->sstatus; dev->sata_dev.serror = resp->serror; dev->sata_dev.scontrol = resp->scontrol; - dev->sata_dev.ap->sactive = resp->sactive; } else if (stat->stat != SAM_STAT_GOOD) { ac = sas_to_ata_err(stat); if (ac) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/