Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1557369pxv; Fri, 2 Jul 2021 06:44:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1SKG2Bq6V+u8CftA181BxD+7K5Q1zkEZgRMN85cvZqz/cJfL50rVw9ImE/HUbIl5JS1nS X-Received: by 2002:a92:6509:: with SMTP id z9mr81898ilb.184.1625233450214; Fri, 02 Jul 2021 06:44:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625233450; cv=none; d=google.com; s=arc-20160816; b=rj/uqayGuNG7BmDozL7mYANIm1tvgAEnfh5yQbjgHmxXX6f44IpiWPoWQzSZGt44Dz 4X5EzK7a9R11Ug71ykaQwOQOcqwAHCsVdKGaVLtGhSoCjf8khkDhTf1IXjuNq+JmaPoU BnPEgXKz4ByGL+iiXwdcwx5YayCk8Y1Y5pxFD2brZGdWviBkDn2299tlF5WbAUsxLE6K vNLmCbyaV5/x8BF8JhSwRPx3fGSKk2Id3TvzTzAsmUpwvi9A1wWiy0HgwOHZYWjVQI0s BOjM2+ODzt7eXzYvtMK9FtMtCTqZpSHBpuFpJnikTi39+02aG6QgH/UINw4/Rh/sz0UY msEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EY1uQ/oG4OPw95tsiXTCjJDhMQik8Zsz56CTGDg43oY=; b=xw/t8c/O4ir5ZAmD3j9JfEfcLYdzmJt0tUgubodfAlrVCSe4IBkaP3qIJrHrx5mn/u iV0qL54ezxHt5bzRU8I3DWragw6YSP6pnxeLgu83XjZPwn28FCkIjKQvLVtunWeqgza6 vAMqHeEo8LwiMRlZHm+PcINR04DsFZ4Gob1gDmIu6VT319PAHOBV7p0Cf3sfj60UYZqW G2X2Ezr6Sq9G+EOYikOjo3SnSBYTOn8Cpu8PVThF8swdxibuYNvFtln3bJ029X7oeZ1M LPGNjmXaMSRjgY4O9J4UtF2/ACNfI0PZ0gIq3Ic3uzF9rFGBnWShXzPjLR8WgV0aXgOg Aajw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hJrROcYy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f20si3760093jat.99.2021.07.02.06.43.57; Fri, 02 Jul 2021 06:44:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hJrROcYy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232741AbhGBNpa (ORCPT + 99 others); Fri, 2 Jul 2021 09:45:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:48822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232714AbhGBNp2 (ORCPT ); Fri, 2 Jul 2021 09:45:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8ED306142C; Fri, 2 Jul 2021 13:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625233376; bh=iQ511ti6tPKWj9+Fpr2R4MwXkxW+DRti6nYPHc/VfnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hJrROcYyJBc/V9bdA4lRLf5PAh6VGY6cP/rxMpe0lJy32mBWVKnZsPZyDqxaGR5mS knrn9+2pYfVRsUyxGCokMIkRbWJwtFwkc1nGYE8U904yUQCxv7rd+6It3KmpIcCtn2 LZ5My1NvIAXgXtBJf8oidsjG3v1J5UYEBShvQVcNTmAU+nw+mM0i7FyLGFZULqJFgL 3MTYnpKGaN7d5Dge+GRV+7z4gxtKmet3OdIWqI6GO5KAl6O3+iPMKKNOcltjJ/ByJN 5kJbPiaSC50QzzdrrsbvnSYGd0hrtLXZQxrze6sqSuzttl70OiqCqisNDMcL4d4Yhh rquobRv8M5Uiw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1lzJRT-0006QH-Cv; Fri, 02 Jul 2021 15:42:51 +0200 From: Johan Hovold To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] USB: serial: cp210x: determine fw version for CP2105 and CP2108 Date: Fri, 2 Jul 2021 15:42:27 +0200 Message-Id: <20210702134227.24621-7-johan@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210702134227.24621-1-johan@kernel.org> References: <20210702134227.24621-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CP2105, CP2108 and CP2102N have vendor requests that can be used to retrieve the firmware version. Having this information available is essential when trying to work around buggy firmware as a recent CP2102N regression showed. Determine and log the firmware version also for CP2105 and CP2108 during type detection at probe. Signed-off-by: Johan Hovold --- drivers/usb/serial/cp210x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 0f4cdba160d9..7908e336f962 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -399,6 +399,7 @@ struct cp210x_special_chars { }; /* CP210X_VENDOR_SPECIFIC values */ +#define CP210X_GET_FW_VER 0x000E #define CP210X_READ_2NCONFIG 0x000E #define CP210X_GET_FW_VER_2N 0x0010 #define CP210X_READ_LATCH 0x00C2 @@ -2103,6 +2104,10 @@ static void cp210x_determine_type(struct usb_serial *serial) } switch (priv->partnum) { + case CP210X_PARTNUM_CP2105: + case CP210X_PARTNUM_CP2108: + cp210x_get_fw_version(serial, CP210X_GET_FW_VER); + break; case CP210X_PARTNUM_CP2102N_QFN28: case CP210X_PARTNUM_CP2102N_QFN24: case CP210X_PARTNUM_CP2102N_QFN20: -- 2.31.1