Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for
 BLIST_MEDIA_CHANGE devices in runtime_resume()
To:     Martin Kepplinger <martin.kepplinger@puri.sm>,
        Christoph Hellwig <hch@infradead.org>
Cc:     jejb@linux.ibm.com, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org,
        martin.petersen@oracle.com, kernel@puri.sm,
        stern@rowland.harvard.edu
References: <20210630084453.186764-1-martin.kepplinger@puri.sm>
 <20210630084453.186764-3-martin.kepplinger@puri.sm>
 <YN3WD4Vem5Zx8Dvq@infradead.org>
 <b1d39dfbe1398192ef1181fc98d6b7e6bedeb649.camel@puri.sm>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <232717d6-fa10-aaec-cd15-8ed5e7e1117e@acm.org>
Date:   Fri, 2 Jul 2021 06:43:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <b1d39dfbe1398192ef1181fc98d6b7e6bedeb649.camel@puri.sm>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/2/21 1:04 AM, Martin Kepplinger wrote:
> Am Donnerstag, dem 01.07.2021 um 15:49 +0100 schrieb Christoph Hellwig:
>> On Wed, Jun 30, 2021 at 10:44:52AM +0200, Martin Kepplinger wrote:
>>> +       struct scsi_disk *sdkp = dev_get_drvdata(dev);
>>> +       struct scsi_device *sdp = sdkp->device;
>>> +       int timeout, res;
>>> +
>>> +       timeout = sdp->request_queue->rq_timeout *
>>> SD_FLUSH_TIMEOUT_MULTIPLIER;
>>
>> Is REQUEST SENSE reqlly a so slow operation on these devices that
>> we need to override the timeout?
> 
> using SD_TIMEOUT works equally fine for me. Is that what you'd rather
> like to see?
> 
> Bart, is SD_TIMEOUT equally ok for you? If so, I'll resend with your
> reviewed-by.

Hi Martin,

I prefer sdp->request_queue->rq_timeout instead of SD_TIMEOUT since the 
former is configurable via sysfs.

Thanks,

Bart.