Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1559603pxv; Fri, 2 Jul 2021 06:47:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFwi0f5+Bqw0wSolO1zoHnA0UzLR7/vcM/EF5i/WSlgRTBFAlxIwxE+GF9c6kBC9prQ8C1 X-Received: by 2002:a05:6e02:1a6c:: with SMTP id w12mr107805ilv.6.1625233651552; Fri, 02 Jul 2021 06:47:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625233651; cv=none; d=google.com; s=arc-20160816; b=T8shaJdiOo6LIPvNJmsEz6tnnn1yD+pLuOJq4IabZlbjGl9v5bD+6Q2qdsYbtA2ry+ QqjZ7xHnUNuItyr+pqZ3R2/vn2/LnCVxYqZU94k7M5pLNY9ARgBIQ2sdnbFNmVzliNzh PLBtvCiNqx+PGTY+ytPyVtCIWZ97YG8QqBgy+d67w5xaW2M2DP5gi5jf3XeGOSYD/019 6preQfOXFLNBM3TDTr5NtilMggJMpXlR5MSphbVGDTC724ZVkh3gdhJgWM/wMHkaJrB9 YyyOYTLVhvbX3Y4SdpWUyZ2rNtIoCMaGTtI/uYI5q4wmYkEmXi2sTbUikrY75TImXxpI U+HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ALmwgqUw8xCCQst4oxbjM/eh7ulpVe3fZ6mcmGg55Uw=; b=bmOw7n7oNOFTdZDJ5vv56jxYlE2rrUWk6y/TxHJPZf/hmKiN/oMH0uhb+gbyXdCVb3 leFiwryHoxbdp2O1ERJrM2K3TLqfdjKim9IpjTBCk/sGMMuk5X84N8HTdi7/tWqgMdg3 IqhN1CXyu+KZ3T1vWquilDbVrItFIntYwTJMmF7f9QC+SdzQpEfKb36hu4UqtQmqO/Nq 5GdSIArjMPw3Ys/EJ2rsCJy8zyU4iH1ChCpGpFO8zCx55iC16uN/JmMiQfwqSYgU8IJn 8tSp443ta///59FH+lnjw/cCLxYncM+CJWE8BTK6vo2kGEgy/ZGOw9IV6EmBU17A9sum nU8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bhn09Cgs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m15si3868219jat.45.2021.07.02.06.47.19; Fri, 02 Jul 2021 06:47:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bhn09Cgs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232666AbhGBNsI (ORCPT + 99 others); Fri, 2 Jul 2021 09:48:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37458 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232654AbhGBNsH (ORCPT ); Fri, 2 Jul 2021 09:48:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ALmwgqUw8xCCQst4oxbjM/eh7ulpVe3fZ6mcmGg55Uw=; b=bhn09CgsSPQf9ZVxXwDa9BXfQ5 IRq5RNnWOXslOZtra05ujQBMe61psPP91RhrcmxTvlDqeie7TwwnxLOqr4zYx/BPDGpaOyP6EeE26 fa0Ot0jXfJM8PKs2b/RJBVLg0v9EYwA7Kla2N50yL4gbKTkx2t7AXWdpFKVqmgN5RvAc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lzJU5-00BvIA-6i; Fri, 02 Jul 2021 15:45:33 +0200 Date: Fri, 2 Jul 2021 15:45:33 +0200 From: Andrew Lunn To: Matthias Schiffer Cc: Linus Walleij , Bartosz Golaszewski , Lee Jones , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 02, 2021 at 02:23:47PM +0200, Matthias Schiffer wrote: > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > causes warnings with newer kernels. > > Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a > missing IRQ properly. > > Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") > Signed-off-by: Matthias Schiffer The system i was using this on made use of interrupts, so i never tested with it missing. It is a shame platform_get_irq_optional() does something different to all the other _optional() calls :-( Reviewed-by: Andrew Lunn Andrew