Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] mtd: core: handle flashes without OTP gracefully
To:     Michael Walle <michael@walle.cc>, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>
References: <20210702093841.32307-1-michael@walle.cc>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <499cf369-c98a-ac48-dfe6-6903314e9606@roeck-us.net>
Date:   Fri, 2 Jul 2021 06:49:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210702093841.32307-1-michael@walle.cc>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/2/21 2:38 AM, Michael Walle wrote:
> There are flash drivers which registers the OTP callbacks although the
> flash doesn't support OTP regions and return -ENODATA for these
> callbacks if there is no OTP. If this happens, the probe of the whole
> flash will fail. Fix it by handling the ENODATA return code and skip
> the OTP region nvmem setup.
> 
> Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Michael Walle <michael@walle.cc>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/mtd/mtdcore.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index b5ccd3037788..6881d1423dd6 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -880,7 +880,10 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd)
>   
>   	if (mtd->_get_user_prot_info && mtd->_read_user_prot_reg) {
>   		size = mtd_otp_size(mtd, true);
> -		if (size < 0)
> +		/* ENODATA means there is no OTP region */
> +		if (size == -ENODATA)
> +			size = 0;
> +		else if (size < 0)
>   			return size;
>   
>   		if (size > 0) {
> @@ -896,7 +899,10 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd)
>   
>   	if (mtd->_get_fact_prot_info && mtd->_read_fact_prot_reg) {
>   		size = mtd_otp_size(mtd, false);
> -		if (size < 0) {
> +		/* ENODATA means there is no OTP region */
> +		if (size == -ENODATA) {
> +			size = 0;
> +		} else if (size < 0) {
>   			err = size;
>   			goto err;
>   		}
>