Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1571885pxv; Fri, 2 Jul 2021 07:05:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4jzZYVv8YM4yTcKFXdsDTkE+Sp6Pa32NIGfxet8+Sb+gWdhmPE/jRKO4vJPIwKVh8w0YT X-Received: by 2002:a17:907:2d27:: with SMTP id gs39mr5522837ejc.328.1625234707192; Fri, 02 Jul 2021 07:05:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625234707; cv=none; d=google.com; s=arc-20160816; b=esTXxRy4EXJCEjHzZJ26V8U/oyJTGXmRBDz1l156doWc50SlV32XK9tWw3zIB5mR2z XAF3xUYGDw9kAfLgDSeAApb2hR2eo3Qdk5taaiN9dwTPmo5YJM85xaHT9uQw6txewzZj dg4lklS7zU3DG96EdFjDG+DUTOavOsNHR5l6AyQ6l9iQhqziwTbqUCJzKRFaiPfRNi3r PPOS5h8xCmsXQcWpRFTnkX4rgp65YM+0NnnH+8V7D8U9V1QvsvROGWgQYHqZH+54j2V9 xEPodTEmfyi2GpZgW4UUHKjA6TnB/NEdjnLZpYnCrtk08YkJ0wnnSTTrYgzLBIB4WBmx AlnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Vl3cuQ6pgPX+CYpO04S3WOZYIRoe6L+AXs1/oGfSePk=; b=ptAegxS4HdptSqNgAFc3BePGO6+3BRgM3foG85BNMoS3uQ9/9RTNJjIuSiquz3kTRg mKvnRxt9XlqHEvE6esNXtWINNzv0FYOoTfxHqm5OBSci9Wl5xY1MeqSg9PIXj0iP0T8I +BuqtZVxdJyVgq2WgTau/4JKqcJH4TGWVFjgZd2no0z+JWMq14E/Z2zSS+pjUAnDWpS8 JhdXEh25i9Co3Qo85Y0NvYIHzvVyr3fFMSWo4f2MTk5oseY859U0JsVdaVRzMEetoDWo J0l6HprhTInMueqnGI2E10TVia/JX15+dSQle5gJLLHqkG/pGh7rmxlVQyeUcnFVFsAK /gQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aj11si3165827ejc.622.2021.07.02.07.04.39; Fri, 02 Jul 2021 07:05:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233014AbhGBOFL (ORCPT + 99 others); Fri, 2 Jul 2021 10:05:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:23721 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232537AbhGBOFL (ORCPT ); Fri, 2 Jul 2021 10:05:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10033"; a="196022697" X-IronPort-AV: E=Sophos;i="5.83,317,1616482800"; d="scan'208";a="196022697" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2021 07:02:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,317,1616482800"; d="scan'208";a="482452300" Received: from aubrey-app.sh.intel.com (HELO [10.239.53.25]) ([10.239.53.25]) by FMSMGA003.fm.intel.com with ESMTP; 02 Jul 2021 07:02:11 -0700 Subject: Re: [PATCH 2/2] ACPI: let BIOS fall back to legacy handling if PRM disabled To: "Rafael J. Wysocki" , Aubrey Li Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List , Dan Williams References: <1625209430-19934-1-git-send-email-aubrey.li@intel.com> <1625209430-19934-2-git-send-email-aubrey.li@intel.com> From: Aubrey Li Message-ID: Date: Fri, 2 Jul 2021 22:02:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/21 7:37 PM, Rafael J. Wysocki wrote: > On Fri, Jul 2, 2021 at 9:03 AM Aubrey Li wrote: >> >> Based on _OSC PRM bit, BIOS can choose switch from legacy handling >> to using PRM. So if CONFIG_ACPI_PRMT is disabled, this bit should >> not be set to let BIOS fall back to the legacy handling (such as SMI). >> >> Cc: Dan Williams >> Signed-off-by: Aubrey Li >> --- >> drivers/acpi/bus.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c >> index 60fb6a84..30a3d4a 100644 >> --- a/drivers/acpi/bus.c >> +++ b/drivers/acpi/bus.c >> @@ -303,7 +303,9 @@ static void acpi_bus_osc_negotiate_platform_control(void) >> >> capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_HOTPLUG_OST_SUPPORT; >> capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT; >> +#ifdef CONFIG_ACPI_PRMT >> capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PRM_SUPPORT; >> +#endif > > What about using if (IS_ENABLED()) instead of #ifdef? aha, sorry, using if (IS_ENABLED()) is better, will come up with a new version soon. Thanks, -Aubrey