Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Jul 2021 16:15:06 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Stefan Riedmueller <s.riedmueller@phytec.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] dt-bindings: media: mt9p031: Add missing required
 properties
Message-ID: <YN8RWoy0xryBw3bL@pendragon.ideasonboard.com>
References: <20210702095922.118614-1-s.riedmueller@phytec.de>
 <20210702095922.118614-4-s.riedmueller@phytec.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210702095922.118614-4-s.riedmueller@phytec.de>
Precedence: bulk

Hi Stefan,

Thank you for the patch.

On Fri, Jul 02, 2021 at 11:59:19AM +0200, Stefan Riedmueller wrote:
> Add missing required clocks and supply regulator properties for the
> sensor input clock and vdd, vdd_io and vaa supply regulators.

Can I volunteer you to convert these bindings to YAML first, and add the
properties on top ? :-)

> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> ---
>  .../devicetree/bindings/media/i2c/mt9p031.txt        | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> index cb60443ff78f..4437d0e3147d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> @@ -9,6 +9,12 @@ Required Properties:
>  	(a) "aptina,mt9p031" for mt9p031 sensor
>  	(b) "aptina,mt9p031m" for mt9p031m sensor
>  
> +- clocks: Reference to the sensor input clock
> +
> +- vdd-supply: VDD supply regulator
> +- vdd_io-supply: VDD_IO supply regulator
> +- vaa-supply: VAA supply regulator
> +
>  - input-clock-frequency: Input clock frequency.
>  
>  - pixel-clock-frequency: Pixel clock frequency.
> @@ -29,6 +35,12 @@ Example:
>  			reg = <0x5d>;
>  			reset-gpios = <&gpio3 30 0>;
>  
> +			clocks = <&sensor_clk>;
> +
> +			vdd-supply = <&reg_vdd>;
> +			vdd_io-supply = <&reg_vdd_io>;
> +			vaa-supply = <&reg_vaa>;
> +
>  			port {
>  				mt9p031_1: endpoint {
>  					input-clock-frequency = <6000000>;

-- 
Regards,

Laurent Pinchart