Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1625615pxv; Fri, 2 Jul 2021 08:17:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/sRXgiWuW5C3IsdQAEp7q+PcfD3ribwbT3+Tw1tOOd2eH0mk3Y/XP68/yLNDnajRqTyGs X-Received: by 2002:a05:6e02:528:: with SMTP id h8mr339156ils.127.1625239031762; Fri, 02 Jul 2021 08:17:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625239031; cv=none; d=google.com; s=arc-20160816; b=ISJYMOgjItfGX44ZanI5gi9cWT6BXLwhDlbYXKv4QhBEpJ/OCUEuZL7sHjCDJwGXh5 HIl4ayJPgg3/nS9/U7Ook4mhq+vQUS8JyuQIdCjOUAz2XjVHouanZwY2h3CawFjl8dVW 5fVPyx3dxhFkMFTvc7lVqT7uqTFG4owba0F1Za33zW5Ppr6Rr1tXn3W0rl8Sou9DGXpF 3P/n1JFLUXew5M66UofKBU+tSlLGOqEcgldjXwAEY7GyYguFBC6ccbPWTWquUcasmNjk 7kRruLmCiJMfasEUd9oo/+NT+fPBeF3uKFVJ5e9SxPy2Ddzl1N7hUENZibgKdMH1HNQr gUug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=5OiazpL1g0tVUfFVlkZ8A59wpegEfYU1y59nlH9/ddg=; b=kQat/+dtr5x0zOsemScGiedlsAOOPO5Aef/zj0zzPC71xQa7P1k2dA1+GDVlCMsH/p 5RZzwuGsxzoZ2sNRSCnZR6cvmS8xNsk5cl2rc3uWu+kGlpqJ+YE/R+e35ajslEDab5Eh SXWpyJlZ0wf8PaIQg9uMPzWIWbltwdsNg6whKAldxvT+LAt2tqtZUQFGgfX9g/nyu1oW BII+SieNJuUpx8bvkijcQwQllJsG7wI5DoIeWjkiMSb+3Yv/G3jtdBQ97HTKpCoiPxlG s3CANTSI2JIxEKFxA9d4ju+MquCJtRdd3QjEavWG23094XmKlxM3uLZkoxwo4fAAABmX tRPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si2581780jar.113.2021.07.02.08.16.57; Fri, 02 Jul 2021 08:17:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233018AbhGBOvf (ORCPT + 99 others); Fri, 2 Jul 2021 10:51:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:16479 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232381AbhGBOvf (ORCPT ); Fri, 2 Jul 2021 10:51:35 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10033"; a="205734472" X-IronPort-AV: E=Sophos;i="5.83,317,1616482800"; d="scan'208";a="205734472" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2021 07:49:02 -0700 X-IronPort-AV: E=Sophos;i="5.83,317,1616482800"; d="scan'208";a="409527191" Received: from tkhalx-mobl.amr.corp.intel.com (HELO [10.252.132.13]) ([10.252.132.13]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2021 07:49:02 -0700 Subject: Re: [PATCH v3 1/2] x86/ioremap: fix the pfn calculation mistake in __ioremap_check_ram() To: Yaohui Wang , tglx@linutronix.de Cc: luto@kernel.org, peterz@infradead.org, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org, luoben@linux.alibaba.com, Tom Lendacky , Brijesh Singh References: <20210621123419.2976-1-yaohuiwang@linux.alibaba.com> <20210621123419.2976-2-yaohuiwang@linux.alibaba.com> <94a38542-b639-37e4-1b53-29b59c5ea655@intel.com> <34bae667-180f-ce97-ee55-12e13ff28ca0@linux.alibaba.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <663229c2-1957-2af5-678c-5d553507f5f3@intel.com> Date: Fri, 2 Jul 2021 07:49:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <34bae667-180f-ce97-ee55-12e13ff28ca0@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/21 3:05 AM, Yaohui Wang wrote: > On 2021/7/1 22:41, Dave Hansen wrote: >> Was this issue found by inspection, or is it causing an actual problem >> in practice? > > This issus truly caused terrible perforamnce downgrade in the practice. > When developing an out of tree module in our testing environment, > invoking ioremap() on normal RAM causes apparent CLI lag. The Unixbench > score also decreases a lot (5x slowdown in the worst case). > > Debugging such performance issue is extremely difficult, especially when > the code of the faulty module itself is already very complex. I tested > the system in many aspects before finally located this problem. Do you know why this check: > if ((res->flags & IORESOURCE_SYSTEM_RAM) != IORESOURCE_SYSTEM_RAM) > return false; did not catch your out-of-tree driver's errant ioremap()?