Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2224275pxv; Sat, 3 Jul 2021 02:44:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU2i9z4D/M2+/xWzxYuyUFeBdbK/lYyCcqukUx6ID+A4tsdFQE53jyJvrduUKhs5ZpJT1S X-Received: by 2002:a92:cd41:: with SMTP id v1mr3093761ilq.180.1625305445334; Sat, 03 Jul 2021 02:44:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625305445; cv=none; d=google.com; s=arc-20160816; b=lR/EG4zZGJZpdX2ld/475os3cfP7c2CwiI0q+fGdP+PhqcceHRXAhc140bl1c5ercP Wi2KNyROv5pGFI68MUMd5iKVQ2VwsZhVG0YfTriXZ5MCRvaM45trUk5hEvDotJCLw+6/ CjOWpq3o4qQDOXINSd8tkzJsuH9EkJMhBBowZkDMFlIHufIus2a5rPQ9K1IYsdzrVcf0 ++jf28jPF4JINqmuDk1CGtHpmUM99Hg5sGWrbROz8HNeKY4kMxkHj0ke9uTJlFzIlhY2 hwbIwP1GMqBeIr9pbiCXvFinMFlCieJFCbjz9wMxz333fApbiXiaTtFwnqsh2on8pY+/ qlrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=K7by/rLQnepTYM6xdZGeYphQVo3N+q+kXJnanh/kHN4=; b=eVDLgkAozeMtXs3WYcQQkDnEk0Lpj6bS5mKAKR4p5Qeesf8qy08Jy7PXUA416I9r05 mpa1DTGO8Wq9J5jbX4/xn2UYVk8fgoNpSz4eLYrh5nhMPSlMY/FOX13VBmv/KEpc7Bh+ c0+Zl4F0vAGkUWaZDf1gyMNxB5XEECgr0V3xMGcJi3aiFXHnnVumiGVY3uXNE84HIaVs r0N7L9tEkkpRk2DP5RV/hA8Pyp7XFUSALKGyjJfoRqXw4W7j6HCHJ9XOe8UekMPDjpNC nirBYcINNF++xDFk8J4oIWMgMDAQrrd7rVIoqOnRGaDHRIpaSwJT7MINiAtOf1pspMg+ GbVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si6202847ilu.43.2021.07.03.02.43.52; Sat, 03 Jul 2021 02:44:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbhGCJki (ORCPT + 99 others); Sat, 3 Jul 2021 05:40:38 -0400 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:46190 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229977AbhGCJki (ORCPT ); Sat, 3 Jul 2021 05:40:38 -0400 Received: from omf08.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id EC976101A3244; Sat, 3 Jul 2021 09:38:03 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA id 60B691A29FE; Sat, 3 Jul 2021 09:38:02 +0000 (UTC) Message-ID: <00de2918fb9bfc46d330a72c535892d8ab992483.camel@perches.com> Subject: Re: [PATCH] ACPICA: fix if condition From: Joe Perches To: gushengxian , robert.moore@intel.com, erik.kaneda@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, devel@acpica.org, linux-kernel@vger.kernel.org, gushengxian Date: Sat, 03 Jul 2021 02:38:01 -0700 In-Reply-To: <20210703091218.650202-1-gushengxian507419@gmail.com> References: <20210703091218.650202-1-gushengxian507419@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.10 X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 60B691A29FE X-Stat-Signature: i6ecosg6rgzwagjcnhqdoy6xdkhtdqnp X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/eBocd42y4w2i2SvyF/lBhyz4B2Rynd40= X-HE-Tag: 1625305082-867487 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-07-03 at 02:12 -0700, gushengxian wrote: > From: gushengxian > > Fix if condition. A few more of these... drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_START, ret, battery)) drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_STOP, ret, battery)) drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(SET_START, &ret, param)) { drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(SET_STOP, &ret, param)) { drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_START, &ret, battery)) { drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_STOP, &ret, battery)) {