Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 3 Jul 2021 12:49:18 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kernel test robot <lkp@intel.com>
Cc:     Colin King <colin.king@canonical.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        kbuild-all@lists.01.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iavf: remove redundant null check on key
Message-ID: <20210703092040.GX2040@kadam>
References: <20210702112720.16006-1-colin.king@canonical.com>
 <202107030209.xwGHO2JN-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202107030209.xwGHO2JN-lkp@intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0037.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Sat, 3 Jul 2021 09:49:40 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e3f4213-dfaa-4613-0b6d-08d93e07e49f
X-MS-TrafficTypeDiagnostic: MWHPR10MB1568:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB156851EFF19F361D8C8A41208E1E9@MWHPR10MB1568.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:534;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Se7n3l9kyXiRxGxO7FsL0kYxqq3QId9krR3sFwD0VUTE3ousu6aclvjLsy8HWJ1Z/G6MYvlXkZgyMEZQaxm6VsjvovGXJIupDKlYaWm9Ez+EiiNqTH/ljz6W4kYWM0wxMrj+knlxQZIsASZcLKTA0cdT31aGN4cqHiZQQyIYHSSvW6CMmzlnNB9GsnTQYTuzL42yQmUjFF9aOiecgGnxUqGtXSCMkFODjhXb3IXt8+2h7TGAr+/+27rOdJoaB8t7xGpiEGExqkxvZk22IcidwL1hv0kx8GQ5HbU7Aq1mzZ5/gWHa2MWhR7vcBi3/DnHx1eloiVvBwVAM1w3aEktWegWJSKzLHMUdIQWIp2ydk4Su2UOflc1Hk3Akj6t9j0bOxVaX5qxxQBUSNbJTIrhlB0M4BvaqjrLEURP/1qpmwZlgSUjMzzcOF1mf3kCBPtyIFQMY6FmfWUjvu6CN58aPz2B+HyTedyjcVWKWK/dSv7LUy9JXnyEfxmLGQTIYlX7m33dSxMpmKdXbjCmkrXNzrurAgy3QrHpuoBYnM58Nn6Qt80685EoPJq4jLyH7rksIob/FHA/3Pj5ejiSgHWVpVCd8L3lVtWUclK8muUKwzP/Bpk7cIOPSOrMLaajR7n6orTrWXAhM2SF2Q+0mZaFF/tS+jTK/7L2+8asGil1PazUSmR3IZQM1xvZU/TWAkVDp0mfKXiGLfDtQnfyvz5CVDw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(136003)(366004)(376002)(346002)(478600001)(7416002)(186003)(66946007)(83380400001)(4326008)(1076003)(33656002)(9686003)(9576002)(33716001)(26005)(66476007)(66556008)(8676002)(54906003)(6496006)(6666004)(55016002)(316002)(52116002)(38100700002)(38350700002)(2906002)(16526019)(4001150100001)(5660300002)(8936002)(6916009)(956004)(86362001)(44832011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EeelIUiTXAuIzCW5z03SGzSUvsqQ8McBcfQV9f8AynQlwX5cBvGDAVfsECe6?=
 =?us-ascii?Q?HOUifd96viK1B1i49GMN8iZjeX77fV0YvDkYtZW+0NtdEvOCAepNLoie78Sn?=
 =?us-ascii?Q?WN3rM1bnOY9QX1zi1auN3GgC3qYTd7USdx8DNwv/ScI/hd2Fed4KkJoNQhHn?=
 =?us-ascii?Q?Cz8iS2MHk+e8Av1XtxK1iDh2LHd6w+XvSINwiZqwIfO7ZTgen6j9boVVJyRi?=
 =?us-ascii?Q?kvHAFmOYn9f9jkCOjCDKP+hI4BMVpW5wEeDVAMq60o7VcoJDHpGLehxFSth0?=
 =?us-ascii?Q?a6z3/iGZr16bx7hSN+enZ0w7r3ZlxeRnpEL0foQdjgZhdrpxn7WteRDqY1pm?=
 =?us-ascii?Q?+UR5nrJDPFGnLzoHqj4EzFawUAPbtz8gJNMPYI7T0khclKeBMbtZY/I0mhSS?=
 =?us-ascii?Q?f5Y02xXmjmsBL7g+nVto/fsGvCB7QAjWV0t/hh5HIf0aQHR0p9OQRyUCVmtP?=
 =?us-ascii?Q?W/abmuxsAh8RFQ3fivKjLNAPIiibDz0K8ky1m2mRgafD/5xxYRL+/yhPEf3B?=
 =?us-ascii?Q?h0k4WYwdT6wcKEh8/42KAs+A2phCOTVjSqawlc6Aj4xQHYHPsdGvKT2w06lO?=
 =?us-ascii?Q?W8Yz0ve0ukzQV7sATglaUE7fZeq5nlF/tOPXjFkV9/5/CVq/O4Pvu7rWibKc?=
 =?us-ascii?Q?gpO89OJFd0Jwsk+ELpAEjAdaXFONGvKl2Vx6iEvOq+D+cUOdrl3Grs0cId02?=
 =?us-ascii?Q?JtTN3P+IWBf/OY1BKpcebh4fvtcOYGXfK8lkYUajvgcS0cT2glVAUysV6PNL?=
 =?us-ascii?Q?aGA+Eb4eSLyBptgldeuDn0bEo7W619+fennfwkXjniGq+JUdzIxeQPGG2gi7?=
 =?us-ascii?Q?pSUIlKTuHORkrwiRJ1OExQ7M6avAKfrtfSe+Vh5H2u87bkAT+P7Opm8k020C?=
 =?us-ascii?Q?AzJk7xJaHA5lddPmGgpfP2w7RWQjlWOnmAsDwCy75lksDg1laWaqKFTSCu+v?=
 =?us-ascii?Q?mH99swXBkZSSW3k1mmJGXRFCjndqaTqvU/K1xxY7zGN9UcmKQB05qCAfrxy3?=
 =?us-ascii?Q?2Y+2lRDehX8hKj2tsWw+8VR7CSzd1reRg1SydbTTiZ3o5IVKC+y+qWHy/gmZ?=
 =?us-ascii?Q?89WgNjn47/Vr9lDps9Zo56HbAhnpXc9kIjhm8a87VBXXxDlHoan9C6xQ2pLn?=
 =?us-ascii?Q?XpuAo91d0fOuxHS7o2AqOmMZ8pW0oLNvZAkuCQrBK5pNkgi0gvsJSp7HK7ZL?=
 =?us-ascii?Q?M3BuM5lf0yoRW4DDD6Yu2BQwrbkPHKGGbLpeCRUo9Iq+02FXoExPs5QUiUyM?=
 =?us-ascii?Q?7VqHjizuFAlKeo7JZOU6Qb4W+Ab3v33ieZgLLYktptO9sDPKQiUYfKcsvFkm?=
 =?us-ascii?Q?X5gGIN89kjG8I7o5B6Nx5PeH?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3f4213-dfaa-4613-0b6d-08d93e07e49f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2021 09:49:47.3795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s0eJp1wgOsZD3j8lyqrFxAmM5af15jSGZbdmLyhWftzxxX0LWUYlgFbmhRlXYPEF2M1SE6WpylXFNTH7yGl6akl3UBIZUpWNdB9sMVw+HSE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1568
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10033 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107030060
X-Proofpoint-GUID: xT7QdpRBXMKJmHTB0Xom3jBLIc_aAjLc
X-Proofpoint-ORIG-GUID: xT7QdpRBXMKJmHTB0Xom3jBLIc_aAjLc
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 03, 2021 at 02:43:46AM +0800, kernel test robot wrote:
> 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_ethtool.c   Jesse Brandeburg 2018-09-14  1899  static int iavf_set_rxfh(struct net_device *netdev, const u32 *indir,
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1900  			 const u8 *key, const u8 hfunc)
> 4e9dc31f696ae8 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Mitch A Williams 2014-04-01  1901  {
> 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_ethtool.c   Jesse Brandeburg 2018-09-14  1902  	struct iavf_adapter *adapter = netdev_priv(netdev);
> 2c86ac3c70794f drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Helin Zhang      2015-10-27  1903  	u16 i;
> 4e9dc31f696ae8 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Mitch A Williams 2014-04-01  1904  
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1905  	/* We do not allow change in unsupported parameters */
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1906  	if (key ||
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1907  	    (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP))
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1908  		return -EOPNOTSUPP;
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1909  	if (!indir)
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1910  		return 0;
> 892311f66f2411 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Eyal Perry       2014-12-02  1911  
> 43a3d9ba34c9ca drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c Mitch Williams   2016-04-12 @1912  	memcpy(adapter->rss_key, key, adapter->rss_key_size);

Heh...  There have been a bunch of patches modifying the behavior if
"key" is non-NULL and no one noticed that it's actually impossible.

:P

regards,
dan carpenter