Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2613908pxv; Sat, 3 Jul 2021 14:52:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvcmI1H7fJjqRoyG+iMt0FHey9gmagTIp0TQaN55VZeymSJIW8FZKqWHt5Xooe0kWMU4Ue X-Received: by 2002:a92:d610:: with SMTP id w16mr4821527ilm.252.1625349130681; Sat, 03 Jul 2021 14:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625349130; cv=none; d=google.com; s=arc-20160816; b=HNpTHHDbDKdexOQVRQ7+xlVcZR6s2xrjAlWYhOKdbV9wmT1A37T1d/XwSPUu70WNfj pkNYL4n3igjC0VHbl7vRkUGlciNYGjoM1JEQLHeKAHPfdwrdavNfbF/Flg+/ezMiWI9i h5jUR/OuAe1lCxUKTYSdx0qUPmX1KSCFVjUHCJz5z6g+YwTbXoBdrGLCSozD13u3dJ5N ajFSq3XrLyzaMSbdfbsFs9+NmJv2q76prH4+ERnDCet4h632FydPr9hKDZ1goioiHE3E 0FClMefjYITqZVSlT+thqMJr3lr7IgkCkZDGAUscBN/Y4K03daPmYBuXGjoDy95zqVrg iVWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ACxvbV8k8rZMZUhUiaTwPLWUqv+wpZnDWYKuTUCTXCU=; b=OvOqoTQImlp/CvqnCs5eafGiMyMPxHk/d0PIJdPz8ZcQaaXBJMPHdZ6bR8EeLDSrYB uD/4OHlH5BEgf3irfiLZRzssANduV/bL3psZVvFCf+qI1mg/WyV3VYQH62ZteUiD7EHc i5GY3V5PvrpBA2x3EDLKtwHIvDp2K73k0/a6HG/4qbmycD8bvYPxYGGGy2M6sxNaf9B7 guqNXp/iSSZV/Drnzhu+KStRXvR4CykP7zy7D+UA1Iyk+STX9Wjr9HqR/iJ7un3kzXz5 hCpH7IHXJAuplG9qXDFhCMDGBrScd4iaARz+2r0sAMCym3i1XkgsdQLYNkzYmzcQZ3mm v2gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si9002878ilm.91.2021.07.03.14.51.58; Sat, 03 Jul 2021 14:52:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbhGCVwd (ORCPT + 99 others); Sat, 3 Jul 2021 17:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbhGCVwc (ORCPT ); Sat, 3 Jul 2021 17:52:32 -0400 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84656C061762; Sat, 3 Jul 2021 14:49:58 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id C45144D3131C8; Sat, 3 Jul 2021 14:49:49 -0700 (PDT) Date: Sat, 03 Jul 2021 14:49:45 -0700 (PDT) Message-Id: <20210703.144945.1327654903412498334.davem@davemloft.net> To: phind.uet@gmail.com Cc: yhs@fb.com, edumazet@google.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, ycheng@google.com, ncardwell@google.com, yyd@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, syzbot+f1e24a0594d4e3a895d3@syzkaller.appspotmail.com Subject: Re: [PATCH v4] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized From: David Miller In-Reply-To: <20210703093417.1569943-1-phind.uet@gmail.com> References: <20210703093417.1569943-1-phind.uet@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Sat, 03 Jul 2021 14:49:50 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nguyen Dinh Phi Date: Sat, 3 Jul 2021 17:34:17 +0800 > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > index 7d5e59f688de..855ada2be25e 100644 > --- a/net/ipv4/tcp_input.c > +++ b/net/ipv4/tcp_input.c > @@ -5922,7 +5922,6 @@ void tcp_init_transfer(struct sock *sk, int bpf_op, struct sk_buff *skb) > tp->snd_cwnd = tcp_init_cwnd(tp, __sk_dst_get(sk)); > tp->snd_cwnd_stamp = tcp_jiffies32; > > - icsk->icsk_ca_initialized = 0; > bpf_skops_established(sk, bpf_op, skb); > if (!icsk->icsk_ca_initialized) > tcp_init_congestion_control(sk); Don't you have to make the tcp_init_congestion_control() call unconditional now?