Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3237123pxv; Sun, 4 Jul 2021 12:04:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAi9gH2M4w5mBEG7S5SOjcgk9YX7BpggcJy+l5VXAMNhVk0NAbxGIA/rllEtUIgDT2t4dU X-Received: by 2002:a17:907:608c:: with SMTP id ht12mr9896493ejc.34.1625425484825; Sun, 04 Jul 2021 12:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625425484; cv=none; d=google.com; s=arc-20160816; b=Gjj+OYbCGmgRU9JcCceVYMjaeMh8ZVhdUgzwMOct1MGzFAaATNLL2OzMCD3q+S++Ju RxieMm4VXm6uCsVYTax/mGYpnQu7ZV8Yv8xCBmmX1c1WkhlgW/b9AXQLnFelYxXjEEcK epIJGs93ICn4C1J2IEdIQj2LI+56fOpNcwLLj3Pln+s98JLmRwiiXt9fQGouuWwU0IfW AKakNyH9gLkrd/uP+FDMdQ29yXpEhgNKsGCy7ixGbuE6e3qFU9YqlvrUB8PoIwafMmyA WCV+ms5ChNmvv4fgLLXUJSL9BSiFSKj1sfxsZ7zSEjLN/S43KmFPW/lakfToq/70f6j5 defw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tu1VfWjMtmVJW6wL3k49D8wTTg74c6wJNYnwEUEgEUg=; b=o4yR1d5lsrGIpmRwe8wTy38To1H/0Ei//oRm0vAl23znpFKB0X8FBbb2fUNXnvGjd6 P5NkXARW4DFHVFeDvy7lwZO4T+DPBkVzbqUeyn4zjzZqoKOFo//DYANxCtSQrj31F2Fb 0GU1hOhwUXAUwekdvEaXUTF0TQfGvG2ZxSfpR5TOCWa574iKCB/+QxIXAZhqBgzOhhba XNXyZpjZzqqr8961YXoH2bErpIyY27M18jmu+xHy+otpUlNoma+Cb/Tj6kyuR+Xg3o1t GNFoEMTGphtK96r8TQCtJqPObGnZodByAtT6o7TrPKaze59Sc4P3BTWL5gG1NptBUPwd BLaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PRh+Mq0I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z64si4545862ede.524.2021.07.04.12.04.22; Sun, 04 Jul 2021 12:04:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PRh+Mq0I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbhGDTFE (ORCPT + 99 others); Sun, 4 Jul 2021 15:05:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:45232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbhGDTFE (ORCPT ); Sun, 4 Jul 2021 15:05:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4CEE6613E2; Sun, 4 Jul 2021 19:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1625425347; bh=C1S3o3r6K16gvr7br8hFJWysya72Q68pIr48FMzjAWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PRh+Mq0I2VF/0nNEoKBVMJ/BUU7x1RvdNnhdSz5PfWstKP85q7Rp/wu2TJ6q2Cy/o 8LCQTJo6YichiCmsS+An8TCxoK7mXWz7VJusw/gL/sIdqUmA8Iep5LBI+m6tt8tCox TrNbT7cSwygQ9fEllp2vcMeXxGERkPwblrp+ECxI= Date: Sun, 4 Jul 2021 21:02:25 +0200 From: Greg KH To: John Wood Cc: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , stable@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bluetooth/virtio_bt: Fix dereference null return value Message-ID: References: <20210704145504.24756-1-john.wood@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210704145504.24756-1-john.wood@gmx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 04, 2021 at 04:55:04PM +0200, John Wood wrote: > The alloc_skb function returns NULL on error. So, test this case and > avoid a NULL dereference (skb->data). > > Addresses-Coverity-ID: 1484718 ("Dereference null return value") > Fixes: afd2daa26c7ab ("Bluetooth: Add support for virtio transport driver") > Signed-off-by: John Wood > --- > drivers/bluetooth/virtio_bt.c | 2 ++ > 1 file changed, 2 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.