Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] rtl8xxxu: disable interrupt_in transfer for 8188cu and
 8192cu
To:     chris.chiu@canonical.com, Jes.Sorensen@gmail.com,
        kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210701163354.118403-1-chris.chiu@canonical.com>
From:   Reto Schneider <code@reto-schneider.ch>
Message-ID: <876caa77-702c-eb29-bfd1-c2ebcc4fb641@reto-schneider.ch>
Date:   Mon, 5 Jul 2021 02:35:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210701163354.118403-1-chris.chiu@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01.07.21 18:33, chris.chiu@canonical.com wrote:
> There will be crazy numbers of interrupts triggered by 8188cu and
> 8192cu module, around 8000~10000 interrupts per second, on the usb
> host controller. Compare with the vendor driver source code, it's
> mapping to the configuration CONFIG_USB_INTERRUPT_IN_PIPE and it is
> disabled by default.
> 
> Since the interrupt transfer is neither used for TX/RX nor H2C
> commands. Disable it to avoid the confusing interrupts for the
> 8188cu and 8192cu module which I only have for verification.

I tested the new code on the GARDENA smart gateway and it works as 
expected. Interrupts are greatly reduced while the same level of TX/RX 
performance could be measured as before the change: A (too) high 
percentage of retransmissions, but otherwise fine.

Tested-by: reto.schneider@husqvarnagroup.com

Kind regards,
Reto