Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 05 Jul 2021 00:23:59 -0400
Message-Id: <CCKX5239AEWI.3T3JF9PXHIESQ@shaak>
Cc:     <peda@axentia.se>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
        <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v3 04/10] iio: afe: rescale: reduce risk of integer
 overflow
From:   "Liam Beguin" <liambeguin@gmail.com>
To:     "Jonathan Cameron" <jic23@kernel.org>
References: <20210701010034.303088-1-liambeguin@gmail.com>
 <20210701010034.303088-5-liambeguin@gmail.com>
 <20210704173639.622371bf@jic23-huawei>
In-Reply-To: <20210704173639.622371bf@jic23-huawei>
Precedence: bulk

On Sun Jul 4, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> On Wed, 30 Jun 2021 21:00:28 -0400
> Liam Beguin <liambeguin@gmail.com> wrote:
>
> > From: Liam Beguin <lvb@xiphos.com>
> >=20
> > Reduce the risk of integer overflow by doing the scale calculation with
> > 64bit integers and looking for a Greatest Common Divider for both parts
> > of the fractional value.
> >=20
> > Signed-off-by: Liam Beguin <lvb@xiphos.com>
> > ---
> >  drivers/iio/afe/iio-rescale.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescal=
e.c
> > index 774eb3044edd..98bcb5d418d6 100644
> > --- a/drivers/iio/afe/iio-rescale.c
> > +++ b/drivers/iio/afe/iio-rescale.c
> > @@ -39,7 +39,8 @@ static int rescale_read_raw(struct iio_dev *indio_dev=
,
> >  			    int *val, int *val2, long mask)
> >  {
> >  	struct rescale *rescale =3D iio_priv(indio_dev);
> > -	unsigned long long tmp;
> > +	s64 tmp, tmp2;
> > +	u32 factor;
> >  	int ret;
> > =20
> >  	switch (mask) {
> > @@ -67,8 +68,11 @@ static int rescale_read_raw(struct iio_dev *indio_de=
v,
> >  		}
> >  		switch (ret) {
> >  		case IIO_VAL_FRACTIONAL:
> > -			*val *=3D rescale->numerator;
> > -			*val2 *=3D rescale->denominator;
> > +			tmp =3D (s64)*val * rescale->numerator;
> > +			tmp2 =3D (s64)*val2 * rescale->denominator;
> > +			factor =3D gcd(tmp, tmp2);
>
> Hmm. I wonder if there are cases where this doesn't work and we end up
> truncating because the gcd is say 1. If all of val, val2,
> rescale->numerator,
> rescale->denominator are primes and the rescale values are moderately
> large
> then that might happen. We probably need a fallback position. Perhaps
> check tmp / factor and temp2/factor will fit in an int. If not, shift
> them until
> they do even if we have to dump some precision to do so.
>

I see what you mean. If we want to do that I guess it would also apply
to other areas of the driver.

> This stuff is getting fiddly enough we might want to figure out some
> self tests
> that exercise the various cases.
>

I never implemented kernel self tests before, I guess it should follow
the example of drivers/iio/test/iio-test-format.c?

Would you be okay to add this in a follow up series?

> > +			*val =3D tmp / factor;
> > +			*val2 =3D tmp2 / factor;
>
> This is doing 64 bit numbers divided by 32 bit ones. Doesn't that
> require
> use of do_div() etc on 32 bit platforms?
>

Apologies for that mistake, will fix.

> >  			return ret;
> >  		case IIO_VAL_INT:
> >  			*val *=3D rescale->numerator;