Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Jul 2021 09:05:55 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Yunus Bas <Y.Bas@phytec.de>
Cc:     "daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
        "stwiss.opensource@diasemi.com" <stwiss.opensource@diasemi.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning
 to debug
Message-ID: <YOK9Yyc31lKr6BzA@dell>
References: <5a718e7812f2ce46347ae94fda6175f38c65359e.camel@phytec.de>
 <20210630105557.eaktwdz5p6yzuron@maple.lan>
 <YNxktsFmlzLcn4+Y@dell>
 <9b5d0003cce92cad57e7712d1e46c78c10f1a0ab.camel@phytec.de>
 <20210702125920.fydyfhwqe7tyr7oi@maple.lan>
 <YN9cl1/7k/UlllSq@dell>
 <20210702191012.mecgw577ggkabxr6@maple.lan>
 <c2ca83c4d67a47a8e104e5c54a4920cac56312b1.camel@phytec.de>
 <YOK1RvQI1rHvaXEy@dell>
 <614d720b0f468334e74a4e29b626d498f25a7c31.camel@phytec.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <614d720b0f468334e74a4e29b626d498f25a7c31.camel@phytec.de>
Precedence: bulk

On Mon, 05 Jul 2021, Yunus Bas wrote:

> Am Montag, dem 05.07.2021 um 08:31 +0100 schrieb Lee Jones:
> > On Mon, 05 Jul 2021, Yunus Bas wrote:
> > 
> > > Thank you for the clarification. I'm now aware on how to handle
> > > MFD's
> > > in the devicetree. But given this, the default behavior of MFD's
> > > should
> > > definitely be documented since i could see many other devicetree
> > > examples handling this also not in the proper manner.
> > 
> > In the 8 years I've been working with DT and MFD, this is the first
> > time this particular issue has arisen, but if you'd like to submit
> > such a document, it will be considered for inclusion.
> 
> This is because on older kernel versions (or at least on the last LTS)
> there was no warning in the first place. The warning was added with the
> following patch of yours:
> 
> Commit 466a62d7642f ("mfd: core: Make a best effort attempt to match
> devices with the correct of_nodes")

Right.  The implementation was decidedly more broken before this and
many sins were lying dormant.  Fortunately, we now have an early
warning system which should catch these kinds of misdemeanours during
initial implementation.

You make a good point about LTS' though.

I'll be sure to keep this in mind as more people update.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog