Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3615392pxv; Mon, 5 Jul 2021 01:24:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4WvTmoHnIG69QP76jO3ZVRPcYLGCqoe1Lq8sB7BiKxgdnf/W+XubfZH42/X7tczVtbm8d X-Received: by 2002:a17:907:778a:: with SMTP id ky10mr12336756ejc.32.1625473488011; Mon, 05 Jul 2021 01:24:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625473488; cv=none; d=google.com; s=arc-20160816; b=1C9RQFuOXFHZj8AW47p7faxZ64PpMzoXl4mHw4aOFoiob4BdOs+09BDpPyu0ScqaXk kY3WVZPhEZcMrf6YVfQFPG5jrDjqsai17jzGIXwrCX8MG8qFj3qw0+ivGhe14wE06hOP eqZ1NvgNSoQM2lQO0Ga9mnTVjA6dSolekXV749w7a4Uu1xN5UT8XkI5URt9wWznE517b vr3ogfM5WdGKFLcIab6srqfLQOyiaIXAZF9a+mhH8glfSPR7MFrKBG+6INRSl33P+Kdk nLxBInkDmqTebT/03TcNdVqcXqZGDmDeta/4hrI3sJJdiNF554GT83ZQcdC7kjjlxWRb uRSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+FtDmO6EV1S+Hi9ICXJmyQ0+zDkvpLCAdKYJGruJaF0=; b=zAv6qNK0G5m8m/q6H33wM4gfQOJ/PKBP0V9LPCZkznBjnx/KyAGoGWy5diUhkqIu6j QYgV8LNxpT7GGRRvw/95Wl5WrB0A9I87MRnNr+Apifln+Nv4ikTz+wFNB83wHmKKjHzJ ifrq/7wXOr6P05ZVe2m1d5V3iTkzv4kY/OM7wKKBJeVujTfwnt6AL/U9DdJRS3S0ORNa Wtkp2FuxvLeoGHwgwXR7A1s5Yron6eYu4D4bJ/ZLoFLUlPj8LYSsxUkp7b+m97S+gwbQ gkIzHyqS0v75aZCfB2Z64TEXlsx46ca9rHvenKdrvVf4FY+KDFYviIvRFP3AUArB0XvO M7Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XzYLpu89; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd1si11410987ejc.483.2021.07.05.01.24.24; Mon, 05 Jul 2021 01:24:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XzYLpu89; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbhGEIXZ (ORCPT + 99 others); Mon, 5 Jul 2021 04:23:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:40910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbhGEIXR (ORCPT ); Mon, 5 Jul 2021 04:23:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DDB1E61415; Mon, 5 Jul 2021 08:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625473240; bh=SYTTcfYK+j/Pfq7K8TLV5XJAAQ7TNgyPYPL1DmPYZgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XzYLpu895mILIUYywEBwmybrW6CpN3rxcCI5ij4RLom+rSkB2Q2DJCJx4Gy9zEq7h L3V+QgzuQMInQumSDAfCQsGT4uAaNHATlfcNLfaoQx3CSGJzNamYL/7PbChrq5Ho0D pwBTyeK7JAxKO+Rju/SdF0fVyXFwIUWBKaeydOmPKbcA2j8gOyAN7B3WE4J3NCDbny C4zyA+S6ZyKTgqI/FeuXj7hUULEEPtHFF1aLP+RNm9LpFJvoPiscuwFj03BkDE9cZO y0Fkc/1nB/Ff8H/sU0EdJhT0NS+KtSwUKnkaSpNCyBQyLNeIgqEbUSzLOBrpD3awk2 q1KxGefktUAog== Received: from johan by xi with local (Exim 4.94.2) (envelope-from ) id 1m0JqF-0004m3-IX; Mon, 05 Jul 2021 10:20:35 +0200 From: Johan Hovold To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] USB: serial: cp210x: determine fw version for CP2105 and CP2108 Date: Mon, 5 Jul 2021 10:20:15 +0200 Message-Id: <20210705082015.18286-7-johan@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210705082015.18286-1-johan@kernel.org> References: <20210705082015.18286-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CP2105, CP2108 and CP2102N have vendor requests that can be used to retrieve the firmware version. Having this information available is essential when trying to work around buggy firmware as a recent CP2102N regression showed. Determine and log the firmware version also for CP2105 and CP2108 during type detection at probe. Signed-off-by: Johan Hovold --- drivers/usb/serial/cp210x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 6aaf54f16f8c..51670c80bf67 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -399,6 +399,7 @@ struct cp210x_special_chars { }; /* CP210X_VENDOR_SPECIFIC values */ +#define CP210X_GET_FW_VER 0x000E #define CP210X_READ_2NCONFIG 0x000E #define CP210X_GET_FW_VER_2N 0x0010 #define CP210X_READ_LATCH 0x00C2 @@ -2107,6 +2108,10 @@ static void cp210x_determine_type(struct usb_serial *serial) } switch (priv->partnum) { + case CP210X_PARTNUM_CP2105: + case CP210X_PARTNUM_CP2108: + cp210x_get_fw_version(serial, CP210X_GET_FW_VER); + break; case CP210X_PARTNUM_CP2102N_QFN28: case CP210X_PARTNUM_CP2102N_QFN24: case CP210X_PARTNUM_CP2102N_QFN20: -- 2.31.1