Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210702163744.265749-1-rodrigo@kinvolk.io> <6322ac90-3491-df4f-7505-db4081bacb79@gmail.com>
In-Reply-To: <6322ac90-3491-df4f-7505-db4081bacb79@gmail.com>
From:   Rodrigo Campos <rodrigo@kinvolk.io>
Date:   Mon, 5 Jul 2021 12:11:12 +0200
Message-ID: <CACaBj2b4PPrP442Kg4X8faOR27=5ozHjwja2FQLSsoOXL+uc8Q@mail.gmail.com>
Subject: Re: [PATCH] seccomp_unotify.2: Add doc for SECCOMP_ADDFD_FLAG_SEND
To:     "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Alban Crequy <alban@kinvolk.io>,
        =?UTF-8?Q?Mauricio_V=C3=A1squez_Bernal?= <mauricio@kinvolk.io>,
        Sargun Dhillon <sargun@sargun.me>, linux-man@vger.kernel.org,
        Michael Kerrisk <mtk.manpages@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 3, 2021 at 11:25 PM Alejandro Colomar (man-pages)
<alx.manpages@gmail.com> wrote:
>
> Hi Rodrigo,
>
> On 7/2/21 6:37 PM, Rodrigo Campos wrote:
> > This flag was recently added to Linux 5.14 by a patch I wrote:
> >       https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t/commit/?id=3D0ae71c7720e3ae3aabd2e8a072d27f7bd173d25c
> >
> > This patch adds documentation for the flag, the error code that the fla=
g
> > added and explains in the caveat when it is useful.
> >
> > Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
> > ---
> > Hi! Here goes the documentation for the flag I just added. Please feel =
free to
> > amend as you want and let me know if something is not clear :)
>
> Thanks for documenting your own addition!
> That makes things much easier :-)

No problem, thank you! :)

>
> It looks quite good to me.

Thanks! It helps to know that the explanation makes sense for others too :)

>
> There are a few minor changes that I applied in a following patch.  I'll
> explain why in your patch inline.  And then you have the diff below your
> patch.

Thanks very much for the explanations, I will try to remember for the
next time. And thanks for sending the patch here :)


Best,

Rodrigo Campos
---
Kinvolk GmbH | Adalbertstr.6a, 10999 Berlin | tel: +491755589364
Gesch=C3=A4ftsf=C3=BChrer/Directors: Benjamin Owen Orndorff
Registergericht/Court of registration: Amtsgericht Charlottenburg
Registernummer/Registration number: HRB 171414 B
Ust-ID-Nummer/VAT ID number: DE302207000