Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "M Tamseel Shams" <m.shams@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
        <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>
Cc:     <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <alim.akhtar@samsung.com>
In-Reply-To: <0c608d5e-f59b-3f05-a461-2205cece4b7e@canonical.com>
Subject: RE: [PATCH v2] serial: samsung: Checks the return value of function
Date:   Mon, 5 Jul 2021 16:34:05 +0530
Message-ID: <014501d7718d$7a8939e0$6f9bada0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQH37JPbw1HOGlkSZQVzgfq3POuaFwHzBW1EAsE0F1iqzZ9PgA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20210630133115epcas5p1706041f122819d47b18b83853b49694e@epcas5p1.samsung.com>
        <20210630133359.59275-1-m.shams@samsung.com>
        <0c608d5e-f59b-3f05-a461-2205cece4b7e@canonical.com>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40canonical.com>
> Sent: Thursday, July 1, 2021 12:06 PM
> To: Tamseel Shams <m.shams=40samsung.com>; gregkh=40linuxfoundation.org;
> jirislaby=40kernel.org
> Cc: linux-arm-kernel=40lists.infradead.org; linux-samsung-soc=40vger.kern=
el.org;
> linux-serial=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> alim.akhtar=40samsung.com
> Subject: Re: =5BPATCH v2=5D serial: samsung: Checks the return value of f=
unction
>=20
> On 30/06/2021 15:33, Tamseel Shams wrote:
> > =22uart_add_one_port=22 function call may fail and return some error co=
de,
> > so adding a check for return value.
> > If it is returning some error code, then displaying the result,
> > unregistering the driver and then returning from probe function with
> > error code.
> >
> > Signed-off-by: Tamseel Shams <m.shams=40samsung.com>
> > ---
> > Changes since v1:
> > 1. Added support to unregister driver on failure of =22uart_add_onr_por=
t=22
> > function call.
> > 2. Commit message updated.
> >
> >  drivers/tty/serial/samsung_tty.c =7C 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c
> > b/drivers/tty/serial/samsung_tty.c
> > index 9fbc61151c2e..188e2d2da201 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > =40=40 -2253,7 +2253,11 =40=40 static int s3c24xx_serial_probe(struct
> platform_device *pdev)
> >  	=7D
> >
> >  	dev_dbg(&pdev->dev, =22%s: adding port=5Cn=22, __func__);
> > -	uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> > +	ret =3D uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> > +	if (ret < 0) =7B
> > +		dev_err(&pdev->dev, =22Failed to add uart port, err %d=5Cn=22, ret);
> > +		goto add_port_error;
> > +	=7D
> >  	platform_set_drvdata(pdev, &ourport->port);
> >
> >  	/*
> > =40=40 -2272,6 +2276,11 =40=40 static int s3c24xx_serial_probe(struct
> platform_device *pdev)
> >  	probe_index++;
> >
> >  	return 0;
> > +
> > +add_port_error:
>=20
> You did not unwind fully s3c24xx_serial_init_port() - clocks.
>=20
Hi Krzysztof,

Yeah, missed the unwinding of clocks.
Will fix this in next version.

Thanks & Regards,
Tamseel Shams