Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210514131750.52867-1-krzysztof.kozlowski@canonical.com>
 <2b427eca-fd6c-d099-337f-39cfbd85cb46@roeck-us.net> <a15e7f62-12a0-1ec7-5104-f01f9e3eccc7@canonical.com>
 <9d98ec40-757d-28c7-1669-a683b2cd3881@canonical.com> <b87bbb80-ed02-447d-f778-7997848731cd@roeck-us.net>
In-Reply-To: <b87bbb80-ed02-447d-f778-7997848731cd@roeck-us.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Date:   Mon, 5 Jul 2021 18:21:48 +0200
Message-ID: <CA+Eumj4aZZPFFB-3PEeBVo6fXW_Fz97oswA3pZuu2aiysnp=nQ@mail.gmail.com>
Subject: Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org, John Crispin <john@phrozen.org>,
        Lee Jones <lee.jones@linaro.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 5 Jul 2021 at 18:08, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
> > On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
> >> On 14/05/2021 09:48, Guenter Roeck wrote:
> >>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
> >>>> When rt2880_wdt watchdog driver is built as a module, the
> >>>> rt_sysc_membase needs to be exported (it is being used via inlined
> >>>> rt_sysc_r32):
> >>>>
> >>>>     ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
> >>>>
> >>>> Reported-by: kernel test robot <lkp@intel.com>
> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >>>
> >>> Acked-by: Guenter Roeck <linux@roeck-us.net>
> >>>
> >>> I don't see a recent change in the code. Has that problem been there
> >>> all along ?
> >>
> >> I think the problem was there always but 0-day builder did not hit it
> >> until recently:
> >> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
> >
> > Hi Guenter,
> >
> > It seems that patch was not applied. Anything to fix here?
> >
> I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
> rt2880_wdt.c"). Does that not solve the problem ?

Yes, that fixes it. It was sent later, though. :(

Anyway, thanks!

Best regards,
Krzysztof