Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4283580pxv; Mon, 5 Jul 2021 19:31:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoL3j2gVzOogk5P6tz6j/+NZeJGFPwyeQUbeGJKKEB1whzgD65xLzNGYss4VSHYS4Vpqus X-Received: by 2002:aa7:db95:: with SMTP id u21mr19752839edt.152.1625538679729; Mon, 05 Jul 2021 19:31:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625538679; cv=none; d=google.com; s=arc-20160816; b=Ek6CdPqf9ijKBIpJrPbygpM6cF0NrrIlLcxaOrt419ggpk4Lz4ScCE1zgTC5g/f9vY q0kY2m3bONiLUMPy4ZVJQct6x1+GRBfOyTncW+GuNIbJkXy2ZM36gfmqAJVBVPwRsDwK j1Gtf5RbQpq1oBsQFf9oBfwjDx/GwLo7+4OZBp0zuJ4n7rTbaUQ6wTGK8Z2Kf9EMRjXZ SZ+HLNcycPa1U9++40JSE6ryjFWwE9gPZwYzEBuj6jqWusjdOlb1d6gQNAW2EvXHIRkd rQQU/guc7GtzPC1gE3s9TlqSu6TmAIMhzL9VNSemjTzLDNxveGjAfdymC0xDA9Xzz/Zk uM8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=y8zDLoIakf2JS4kF/UvXzBzAInmtyJIrmxB9RdTpClQ=; b=mYi/gpwv82BM9BvkSxFjXBhZ5x3SMuIB3fIX8Nml6d0Z3Zwe1fuUDWtj6nrxOO+q+4 Cnw61t1jNoupm4AkX8Iz/fzy5jf5HTB33MucOAXtUhjTheOLKR3CfRm6ZUlAo5Ka2NWW YrIHA6IwrhgZoBUaq51TeDhLNcH9yqPp4t4fqXCnswuSzqU9H4nbDVq/QaWupePC3gnn ZITituWC79icE05FYL7w8GWdNu285Lv+v3xONloaKE3F7D5Mi1HYU225QCIpbHIbAKFp I2CVzxUV6E0GV1cjMbVzHrEZV9XrD/FLULe8ZKbQ5SANfjKhnnBwQLtn7XecyqxME32N wcrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si13153145edk.517.2021.07.05.19.30.53; Mon, 05 Jul 2021 19:31:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbhGFCbR (ORCPT + 99 others); Mon, 5 Jul 2021 22:31:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:12947 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhGFCbQ (ORCPT ); Mon, 5 Jul 2021 22:31:16 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="206035224" X-IronPort-AV: E=Sophos;i="5.83,327,1616482800"; d="scan'208";a="206035224" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 19:27:58 -0700 X-IronPort-AV: E=Sophos;i="5.83,327,1616482800"; d="scan'208";a="456898986" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.147]) ([10.238.4.147]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 19:27:55 -0700 Subject: Re: [PATCH] perf list: Skip the invalid hybrid pmu To: Andi Kleen , acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com Cc: Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com References: <20210610051646.4003-1-yao.jin@linux.intel.com> <77380298-b3d5-d165-c8d4-a24b22d15b0c@linux.intel.com> From: "Jin, Yao" Message-ID: Date: Tue, 6 Jul 2021 10:27:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <77380298-b3d5-d165-c8d4-a24b22d15b0c@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, hi Jiri, On 6/17/2021 12:37 AM, Andi Kleen wrote: > > On 6/9/2021 10:16 PM, Jin Yao wrote: >> On hybrid platform, such as Alderlake, if atom CPUs are offlined, >> the kernel still exports the sysfs path '/sys/devices/cpu_atom/' for >> 'cpu_atom' pmu but the file '/sys/devices/cpu_atom/cpus' is empty, >> which indicates this is an invalid pmu. > > > The patch looks good, but it would probably make sense to fix the kernel to avoid this too. > > Of course the tools patch would still be needed for older kernels. > > -Andi > > Any comments for this patch? Thanks Jin Yao