Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4288917pxv; Mon, 5 Jul 2021 19:41:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeAysmx0Bajj67dZKAyiMTPCnzu7ejNf8L4mxtbO7GNYEztYNkNEe05LpXNtLIXd7c8sEC X-Received: by 2002:a02:606d:: with SMTP id d45mr15251319jaf.86.1625539306778; Mon, 05 Jul 2021 19:41:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625539306; cv=none; d=google.com; s=arc-20160816; b=o9GTKxpMAYYxzfduImybZWfgks0+G0gdgjTQFVX8NUnmUJuegmtXupjPdeWzNo8NKv uTpfFSyZFZvCCntSAaisQ4HIfLHOkXyLqLfcGz7v5zOHwKDZMxIYR/BkSls6ElT+gIl4 vkqbMKJcauinDjvbntMUcuzGXAC69Z3t8a7if1gu74i5NwiVeqgHW6Fw8wYRisA5OC60 rjdYG2mU4RajeV4mdlVsJt6p9kWjlESYeV7hLziAUkBAUBIjIJ1MdTdDo1L5BDZWkXtI 7q+E/w1eeC0HCOZW5dY7aGou114CJ6/QuFsV+7xVHdPkqHMwpNoDI7s1dWj1NtbI/cV9 JWyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:date:message-id:from:references:to :dkim-signature:subject; bh=3F9gcIMfbZAZugjl+Gc1dc/E0wEPvESxt0ZR11S8uhk=; b=km9bBs6hwryGLV03mE9SE3aLgdEHK03MMEmztZ8XvooGzOQw60A2M7em7RoKzc5h1E uxqG47zIx4XjrxdKok22npwT/1RP4tPHlFWOOXv9pfSmyPatKu9AyzybWtaZHHKnI7tI dWgoC936smyOlSuXDSAa9OmUaLP07BQi/hw8/0iGmyVAwRRbc999x9Lli0Bnk9AhR6ZZ XzeRUsYHIHIlbkBVlWaHmUyBps4QVFWH0yBEFKdCs1UFXOO678rgD3HodrOj+4FxNWmO 3QMrjkum5hTNDbmlITHbGHtfgUPZfgZtZhgmnza4QzMhJCx8iubGGW16gaCJyg1wvb1g afOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=HFf+xWY7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si16834156ilu.60.2021.07.05.19.41.35; Mon, 05 Jul 2021 19:41:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=HFf+xWY7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbhGFCnl (ORCPT + 99 others); Mon, 5 Jul 2021 22:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbhGFCnl (ORCPT ); Mon, 5 Jul 2021 22:43:41 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76723C061574; Mon, 5 Jul 2021 19:41:03 -0700 (PDT) Subject: Re: [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1625539261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3F9gcIMfbZAZugjl+Gc1dc/E0wEPvESxt0ZR11S8uhk=; b=HFf+xWY7B6EYQJc8kOMC5nz/SISJnttX8PNc6OLaDzVEF2cKHzRpwNK17mw6pDnnKITUUl G1Ew1Bozw2yvSHU+JMS9I6csi/0Vk7OFoPN5uKx1a0uwuir0Sb8ms3jURtahdkQ9jkRDQY 9DgXZa42F1C1eajXyxfJCjwES0xrBcg= To: Wang Qing , Josef Bacik , Jens Axboe , Chaitanya Kulkarni , linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org References: <1625477143-18716-1-git-send-email-wangqing@vivo.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang Message-ID: Date: Tue, 6 Jul 2021 10:40:54 +0800 MIME-Version: 1.0 In-Reply-To: <1625477143-18716-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: guoqing.jiang@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/5/21 5:25 PM, Wang Qing wrote: > Must release the queue before freeing the tagset. > > Fixes: 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk") > Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com Did syzbot actually test the change? > Signed-off-by: Wang Qing > Signed-off-by: Guoqing Jiang I don't mind you sent it quickly, but pls remove my outdated mail account. Guoqing