Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4352395pxv; Mon, 5 Jul 2021 21:50:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4zpuZaxhuSCtWSTjvxoa3ojK/Y+y8yg1F7A9XHJQq7Q+S9v6pGf5bqGxJoNS9Q4Z7EUYV X-Received: by 2002:a05:6402:430d:: with SMTP id m13mr2110895edc.88.1625547050703; Mon, 05 Jul 2021 21:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625547050; cv=none; d=google.com; s=arc-20160816; b=KdEALUX80bHxEvCO6U8Qh0zNu27Ql2B7NEyP6lz8iqYD2vwRGT/0tWxehT1ZS13pXN nGheJt9c+mavJjZxQVQdEEw+G94iulkv70vwe3FMbap+E4RVjPTbv7KlYeKuJtLJBDOZ uvRimJv9wNzzXABUWCZDZAeOfhUl9xX3iRfASMTiMVaiFZfN6HSMjtbYzrmCEBPYRY+a y/gieEKmLNUbmXn5X7j/+AEIE0Zi52yaTEyCIBc0pPs77d4KK/52su160FYzUzkCb4V2 +WTUxLm7LcS2xIy8hP3JNaQnFLpN/5AYP2xzNunTtICYvcYQl6Z3KrKi2zk4juvpXfCV z+sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=mmPDq6jhLopwYpMlNUZOyBB9q/XTgvaDF/3AwkUR1fY=; b=gECgmDyNyDupd8W/MoXHsa+/eLDHsGemIJhLRs8Z/2g9pC31hZ5iih86fHFGN9c57V imgh3rH5LU0MvtZYzg7ZWbk5flTYM6muWDBMyKIJqmzREyLSJHrk9K/S4PtpxmueBhxe XbaFfgpJpuFD3st1lcECYvmHkXLaexym0i8mgNDAA7Wjc4wU1YETUjSKngP2zKbCl1WD rQr6pJTCXm5ObVDzocOgH9sN07oL3jdK4ugKEN6Wy8KJR09fYNTHj7tXcXLe1pk7zqbS n2L3NRokadpBTxRBdp0gmiHGRy2zHEhaiHppYyBMf/tr1SJhKXpHtxcoK+jXJM/Js2oz ENPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hd33si12795494ejc.706.2021.07.05.21.50.26; Mon, 05 Jul 2021 21:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbhGFEvd (ORCPT + 99 others); Tue, 6 Jul 2021 00:51:33 -0400 Received: from verein.lst.de ([213.95.11.211]:59053 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbhGFEvd (ORCPT ); Tue, 6 Jul 2021 00:51:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 25C5068BEB; Tue, 6 Jul 2021 06:48:49 +0200 (CEST) Date: Tue, 6 Jul 2021 06:48:48 +0200 From: Christoph Hellwig To: Will Deacon Cc: Nathan Chancellor , Robin Murphy , Claire Chang , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, Tom Lendacky , Qian Cai Subject: Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing Message-ID: <20210706044848.GA13640@lst.de> References: <20210630114348.GA8383@willie-the-truck> <20210701074045.GA9436@willie-the-truck> <20210702135856.GB11132@willie-the-truck> <0f7bd903-e309-94a0-21d7-f0e8e9546018@arm.com> <20210705190352.GA19461@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210705190352.GA19461@willie-the-truck> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 05, 2021 at 08:03:52PM +0100, Will Deacon wrote: > So at this point, the AMD IOMMU driver does: > > swiotlb = (iommu_default_passthrough() || sme_me_mask) ? 1 : 0; > > where 'swiotlb' is a global variable indicating whether or not swiotlb > is in use. It's picked up a bit later on by pci_swiotlb_late_init(), which > will call swiotlb_exit() if 'swiotlb' is false. > > Now, that used to work fine, because swiotlb_exit() clears > 'io_tlb_default_mem' to NULL, but now with the restricted DMA changes, I > think that all the devices which have successfully probed beforehand will > have stale pointers to the freed structure in their 'dev->dma_io_tlb_mem' > field. Yeah. I don't think we can do that anymore, and I also think it is a bad idea to start with.