Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4424542pxv; Tue, 6 Jul 2021 00:06:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMJIjkxc44GwUND+xsyls5CGR3usmppubEiI4BOpbbnGSbsHnWfhzRXookamTA1tleC2XA X-Received: by 2002:a05:6e02:138c:: with SMTP id d12mr13152362ilo.286.1625555169067; Tue, 06 Jul 2021 00:06:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625555169; cv=none; d=google.com; s=arc-20160816; b=pKK0AuXO7IYRtxyPt0mlwLrPZiMt6m5Jn53VSryTbZexaAs6JCvLO4pJV9s+pKldCL cBlpgjnfxrrs1DIUoAXRMUwNf8AZp1SRc4TWXOjE1XzT5YLG/wsuhx4DxEPcUW2w9wOp sik4Gvhk6gyyrgTb+rQ+IDd0PP3jxBEijlZo/xHI+3uzsoBoBrd4YDdVVt5AfIawSiDQ 7TPdBSgSS2QZJtimw2Nlxc+WwEssFZd2WGlup2yMIqeXXQDONbtFK/qbxZEm4Av8PLaZ eNEoQ72B++mL+e18by8zirWOWDHzGK1x32HlEU+UipkTlathCL6YnT83Ktpc0/rUrws0 eTkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:subject:cc:user-agent:mime-version:date:message-id; bh=f8S+sOm3qOO2clCOGMWbFUuQgOf6EyHd+juRW7/r0TU=; b=MjdHS1bRvGva0QmWhyhhzwcvDih9NRLzBKZ8o44Su6eOoHQiVRIflkKA1W9RsPyKnI qT/glver83rx39lvDaB2E8aNGtYTXCj8vowg2G3Fz8SDMNMFLtGpWn65uxExQcYYpQ9D 82SPjJrgqb3pkhdiY5XwjheS5aVwyPrGBJ+PjqTPU0m25KfQeldgocCpBD+0ZWXPxivZ YEXJiwXuz8hNCRTbAd7k9bitfHKlKYURHJYQu1q+WhKpcfcedpCvIEUqq7UTv+tYF16D NcMtM6EiY7OAvlhEQkhxzBhIqefiusflv8jPdKFDhtZANUIeF2r1tFIWPVsBiDXZuOIe 2qLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si17589074jab.10.2021.07.06.00.05.56; Tue, 06 Jul 2021 00:06:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230199AbhGFHIC (ORCPT + 99 others); Tue, 6 Jul 2021 03:08:02 -0400 Received: from regular1.263xmail.com ([211.150.70.204]:46414 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhGFHIC (ORCPT ); Tue, 6 Jul 2021 03:08:02 -0400 Received: from localhost (unknown [192.168.167.172]) by regular1.263xmail.com (Postfix) with ESMTP id 0224F681; Tue, 6 Jul 2021 15:05:16 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [172.16.12.64] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P31478T139654521145088S1625555114518632_; Tue, 06 Jul 2021 15:05:15 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: shawn.lin@rock-chips.com X-SENDER: lintao@rock-chips.com X-LOGIN-NAME: shawn.lin@rock-chips.com X-FST-TO: ulf.hansson@linaro.org X-RCPT-COUNT: 8 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Message-ID: <8d310df9-2139-e5ff-e0ee-205ffc1778a2@rock-chips.com> Date: Tue, 6 Jul 2021 15:05:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Cc: shawn.lin@rock-chips.com, Adrian Hunter , Linus Walleij , Wolfram Sang , Christian Lohle , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 0/3] mmc: core: Avoid hogging the CPU while polling for busy To: Ulf Hansson References: <20210702134229.357717-1-ulf.hansson@linaro.org> From: Shawn Lin In-Reply-To: <20210702134229.357717-1-ulf.hansson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/2 21:42, Ulf Hansson wrote: > Step by step, code that have been dealing sending CMD13 to poll the card for > busy, have been moved to use the common mmc_poll_for_busy() loop. This helps to > avoid hogging the CPU, for example, as it inserts a small delay in between each > polling attempt. Additionally, it avoids open coding. > > This series takes the next and final step, by moving the mmc block device layer > from its own busy polling loop, into using the common code. > > Please test and review! Hi Ulf, This patch-set looks good, Reviewed-by: Shawn Lin > > Kind regards > Uffe > > Ulf Hansson (3): > mmc: core: Avoid hogging the CPU while polling for busy in the I/O err > path > mmc: core: Avoid hogging the CPU while polling for busy for mmc ioctls > mmc: core: Avoid hogging the CPU while polling for busy after I/O > writes > > drivers/mmc/core/block.c | 74 +++++++++++++++++--------------------- > drivers/mmc/core/mmc_ops.c | 5 ++- > drivers/mmc/core/mmc_ops.h | 1 + > 3 files changed, 37 insertions(+), 43 deletions(-) >