Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4469622pxv; Tue, 6 Jul 2021 01:27:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl/C8LI/8YR35yHqPbfrOcGy+QC2x9bFMslZD3eTjj2+Xuw23ztOxvhwyvSl74GCPHyhsN X-Received: by 2002:a17:906:a195:: with SMTP id s21mr17463252ejy.373.1625560066347; Tue, 06 Jul 2021 01:27:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625560066; cv=none; d=google.com; s=arc-20160816; b=wq6icu3rZvzpuUHehVXdtERCHt3nrYXOBRmw6MfPxAZExdKgkWJLpBMcdYyEVFT78+ fvidX6X1InCx33b1oyh67sNnj8IVLyQivMb4BidWCm/LP0qivFunw3/U5QQG0oMnLWCX UjKn0ef1YV7Vv+u4jlW0kQ+M2EFF8mVeU1WXF5peRnnLQOJKwCSSpnxSxCCE+H2Pe9kw 2WlgLXIIV7EtrLFZy/k+QiP3p0VFupXRU4X139JyXyCENLVCik4rNe2l+2TUYxf6dtAP cwuERLClhDMazKIhVjo0PaUKC3RnRak6pZdG5DrsOAMGJxFy4jBxuOK2nwE6dPRCdQF3 Xzbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VsBR1kPAqwaus4wsl3eEy2clPsB8g8F67D4/h57x3zg=; b=cST1Kgj+VX8i63yzHW9fbVeRkk1+aPifYEu+MwN8YJxJ9wLM8XZ7ovtrBFAp4PNPWj RHWxJpoo5/daNASeRZsaoyUZKUpKSe7TiptKs3UNgyeN8vvZ3DZU32O3XBV6vo/d3dQ8 SEnfiIpWJNbwOMtAFGxJQPD8AfsWCwcXvSE8ntcj/B4mA4caLClO/pVFf1x38TIF2/bv o80aGFqegK/7Eg7OwFRWTCV6p9CwGeEZRZjiSiqeofrjFeSarPL9LU9YfzMo2WNhJEdi WJ+Fab4aiLMkPWHSJRSta907MdQ1+6Ty0ux3PWGed3+pN5zEYKNdojOTGtecUG0KErXm fPZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VXCDKOvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eo9si16178376ejc.528.2021.07.06.01.27.23; Tue, 06 Jul 2021 01:27:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VXCDKOvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230398AbhGFI06 (ORCPT + 99 others); Tue, 6 Jul 2021 04:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230351AbhGFI04 (ORCPT ); Tue, 6 Jul 2021 04:26:56 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78711C061574 for ; Tue, 6 Jul 2021 01:24:17 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id h18-20020a05600c3512b029020e4ceb9588so1065298wmq.5 for ; Tue, 06 Jul 2021 01:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VsBR1kPAqwaus4wsl3eEy2clPsB8g8F67D4/h57x3zg=; b=VXCDKOvpY81S1qjLmasFSh3RxuTWbWxgzyVPBPxUrknaDN9viJmuLPjO4gorF/kH1c 0SXlnrpiGiUA06z1hAtso5FwQ1/lK/oW1WsSULD54XSv761Ta4PZtFfVTctLwZXtoIIG esHaMInPPeJ6xo+/YU7GZdzBvTz0UzTrSGBDn1kfsuY2eWvTGLzagXF/gNZi98PPzHnJ qb8rRsIIHlfBa6zuMUULMGwOTqz15J8Z+TNEwL4Dvii5LsOUGqZxBnO1mLVheDdQDur8 tDHSKfNr6lCK8ogdK4gB9F0fcqwheFKKbe+wf99Xc6IFGBqafj91Kh5e6F06FXqyS2um esxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VsBR1kPAqwaus4wsl3eEy2clPsB8g8F67D4/h57x3zg=; b=t1pySWzzy4eRr0NoAODeW7Xlf0QwcldTJ0KbbZQb/DZZmLKpoGBeWC9LGm6kX0h0m9 kYKb256Umhrz8Lq09zGSRZqxngKYPnXjAlrLGfkEx7JktVbNpwXt6DL4eYL0Ns+MP6Hx fYXqHTK0Cjd9VEdnNeOLekegRvWw/eAozwfFBRBqrAMg4YW3OEQkPhGhaBYtNrdH7NfN 4vjBnWvJXiqhNiuwj87JPhgbvAJSoi83j0nfuU9CcI/8jXI4Y9PyWmGudQzMVND+Y/68 4t5MrVE7UaLAXM5eUb/+3FVVBR5D2NqumJo6pI8uPrH2O6oUq8pq8JVjObo3CPl2MGAW /c2Q== X-Gm-Message-State: AOAM530v0muoadvmDehiA9cwN+6C629sySzN/BWe3UoELX4yjTpAcJ0k q/fLIVmwQVcWpK8UAc+YEPQuIA== X-Received: by 2002:a05:600c:3b0b:: with SMTP id m11mr3408106wms.25.1625559855954; Tue, 06 Jul 2021 01:24:15 -0700 (PDT) Received: from dell ([109.180.115.218]) by smtp.gmail.com with ESMTPSA id d3sm7670088wrx.77.2021.07.06.01.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 01:24:15 -0700 (PDT) Date: Tue, 6 Jul 2021 09:24:13 +0100 From: Lee Jones To: cy_huang Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, axel.lin@ingics.com, cy_huang@richtek.com Subject: Re: [PATCH v2] regulator: rt5033: Use linear ranges to map all voltage selection Message-ID: References: <1625553939-9109-1-git-send-email-u0084500@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1625553939-9109-1-git-send-email-u0084500@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Jul 2021, cy_huang wrote: > From: ChiYuan Huang > > Instead of linear mapping, Use linear range to map all voltage selection. > > Signed-off-by: ChiYuan Huang > --- > Since v2 > - recover the volt number back in rt5033-private.h > - Add the n_voltages from v1 back. > > Even though commit 6549c46af855 ("regulator: rt5033: Fix n_voltages settings for BUCK and LDO") > can fix the linear mapping to the correct min/max voltage > But there're still non-step ranges for the reserved value. > > To use the linear range can fix it for mapping all voltage selection. > --- > drivers/regulator/rt5033-regulator.c | 21 +++++++++++++++------ > include/linux/mfd/rt5033-private.h | 4 ++-- Acked-by: Lee Jones > 2 files changed, 17 insertions(+), 8 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog