Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 06 Jul 2021 10:24:29 +0100
Message-ID: <87eecb94mq.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [irqchip: irq/irqchip-next] irqdomain: Protect the linear revmap with RCU
In-Reply-To: <fb3b9223-a811-af48-ead5-b2c6f7305de4@roeck-us.net>
References: <162341967699.19906.3242958007782554792.tip-bot2@tip-bot2>
        <20210705172352.GA56304@roeck-us.net>
        <87h7h88wsd.wl-maz@kernel.org>
        <79ec0069-553b-cac1-5ec7-d68c757619a5@roeck-us.net>
        <87fsws8uty.wl-maz@kernel.org>
        <fb3b9223-a811-af48-ead5-b2c6f7305de4@roeck-us.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 05 Jul 2021 21:36:36 +0100,
Guenter Roeck <linux@roeck-us.net> wrote:
> 
> On 7/5/21 11:43 AM, Marc Zyngier wrote:

> > It definitely helps, and confirms my hunch. With the patch below, I'm
> > not getting the warnings anymore. I'm pretty sure a number of other
> > MIPS systems suffer from similar issues, which I'll address similarly.
> > 
> > Please let me know if that addresses the issue on your end.
> > 
> 
> Yes, it does. Feel free to add
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
> to the real patch.

Thanks.

> Now the big question: Why does this only affect 32-bit little endian
> mips images, but not the matching big endian images, nor 64-bit images ?

Are you sure these images are using the exact same HW? A bunch (most?)
of MIPS systems do not use irqdomains in their root interrupt
handling, so this issue wouldn't be visible (irq_enter() will already
have been done for the chained interrupt handling).

FWIW, I can reproduce the problem by switching your mipsel config to
BE, and adding this patch fixes it.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.