Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4571242pxv; Tue, 6 Jul 2021 04:20:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLMs7A9I9XrwZ8zmZhjouCxMIzVu2MdPUVvTweHEgcL0Kq8oIAphVq7IkJEN2SXybS94iL X-Received: by 2002:a05:6402:2d6:: with SMTP id b22mr20702445edx.89.1625570426380; Tue, 06 Jul 2021 04:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625570426; cv=none; d=google.com; s=arc-20160816; b=gNxLZeE8yxBn/Nl6ZDUiEnzYtV82tE52TmYyjK52VwHluWVWgn7ICVgJKA/cu2UIOL 9TIuFPvUcCj6ihWLtTdajgDX4apuOUi4DmwMJQGIZS+KZVpYnrp7Dt5czu9UtknKZ3ZR 7wHXj46exExGVNlJwNyxZVvMZj+N7//Jn40gz5JYrr3qfDi17KgtTwMKoL0KS2xshtCL 7fzBIvY0mt2rhVU2y1hL7m58H85khNAnkRwGPLIVTrDB5qSwDH6fbshXIK8vxHHakOWj vqjRmzvXwNd+Cg89nfkx5Wv4gCkLU7F8Dm86x4SJe3knmmqBw3VFpjLhfZjaY6iaex89 GsKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e/aJKaV99JdzmjsFuMf4B8aV5AB9YYvjh3HpyOg/Cyc=; b=rRxJe3Wc+vUofQzbyCcAWQHeWP+lYxEGyvtWi9mALVpsWgW9AOGEUVjUEJKSdxR4bZ O+5UR0/BsutxjadTz2Oh+lRiG/vy/a9HQ5wbCp1djRwp8GBA2ml6xOYhxuz04v0UmwXZ DQXMQeuc6amWUhOdrYpGAGVDNQQQSmQdIbXcpAiu159dJDrbMJmo+xje9lcLEElKQAFU cmGNte/4JOD6o3yeeWRsr6drhc77FtPMocxP4+A8pZLy9/45W6l3wT9HFDvNNzzcsoiY 0gqos/B1VSFIFyt/ed+l4oWw5z2Xz2qrVVcmMU0xRrRhG2mIyzYU6iLYUMP+k6n68bIO c3xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NyG+mtW9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s17si13420865edr.445.2021.07.06.04.20.02; Tue, 06 Jul 2021 04:20:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NyG+mtW9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233151AbhGFLVt (ORCPT + 99 others); Tue, 6 Jul 2021 07:21:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:55090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232350AbhGFLSm (ORCPT ); Tue, 6 Jul 2021 07:18:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2836661C4C; Tue, 6 Jul 2021 11:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570163; bh=n4e4i6b7pu+S+LOQhnplVOflen9SPRukJwk4NQNpG+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NyG+mtW9uayAkgvSkmCKNWQxbqGNl8fkF4hCWN39ivElebpn99gM98LJDgfNkvUXK Xfgo1n9Ep535etd48gchxZZDU754jHq+6eYCFbnvWajPFHlAEGU+t676dVFgPCCRmU 62qNwi5yTzlvTjzKnHMbyq2lewF2TTidUdgdujDV68U9hFxXRFdV/3UHn9Bq1q+AXR OnakG7NcXPptndH5o44FQ+areaZYsfkqVLjMJpH16YdFk/Qe6MF7fQ2XdtePJjFiGJ FqMUi8jZ8GxFzsSSKz+py1Ocptu6gxASHlrfIFV6gr2x26vcedLaYHQ7TFJc+X7tct vF8l/ZxBlFqAg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Florian Fainelli , "David S . Miller" , Sasha Levin , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.13 084/189] net: bcmgenet: check return value after calling platform_get_resource() Date: Tue, 6 Jul 2021 07:12:24 -0400 Message-Id: <20210706111409.2058071-84-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706111409.2058071-1-sashal@kernel.org> References: <20210706111409.2058071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 74325bf0104573c6dfce42837139aeef3f34be76 ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 5335244e4577..89d16c587bb7 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -423,6 +423,10 @@ static int bcmgenet_mii_register(struct bcmgenet_priv *priv) int id, ret; pres = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!pres) { + dev_err(&pdev->dev, "Invalid resource\n"); + return -EINVAL; + } memset(&res, 0, sizeof(res)); memset(&ppd, 0, sizeof(ppd)); -- 2.30.2