Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4571499pxv; Tue, 6 Jul 2021 04:20:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWt6K0iXVVO5pWI5d9x/mWhVFZg/KjNyjYVfAaCUEu60hAf+/TFy1USAR7w6nDH5ZVFhC6 X-Received: by 2002:a05:6e02:18c9:: with SMTP id s9mr14185477ilu.220.1625570447424; Tue, 06 Jul 2021 04:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625570447; cv=none; d=google.com; s=arc-20160816; b=GSeJLtescOWy0uxeVaUt5wKP6YOQ4+B49t3poa3g/3NjyyxU/6Sn96ncrVGd2rD3Pc GbtZeENLg+AEw4ld368nVBNUGeJZsFuSx7QW0tM8qxYH57IB02dBi76LyEmOJqKIiQbv I/9WvwJqQn1Bnx9avri5OhpcnGz0/MIpxO2YDKcnlR9DEnpHC4RM++E5lSSK82hUqt0S dbGF/J8/sJSCcdBBm+Eo0DFbgWdnp10CFpq0pO72sSq0pqBY5jMJcDwWqMwpJ1ji/4qa cF+NZv+PPlwSitA5W4FbzJ42x3AZQDknVV6gC7iVLP2WyQk2d8JfNPICwcgT5jgS2tnX ux4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ri9keRFm7nTRHYSVgIkWKa5sAh/xE7SEws07xC5/Bzk=; b=z1c3u8wCyb2D5gxZ4m4AoI4NJmod4PheDnZSm+D/drMtc/lY6Z6OsiZIamCW5qU0e9 hTm2kuSdSSLzePbEndBrfmIu1FZglDH7hVGvO2SoHZ8BZ2UrJg5xVNvGH2sXcQ9bsivv 1vohuFK2FoUSX/cCrFUaC1lo4qg6wssNlkoOHiNt5O+3PtL/2NPl12cmG7AUv7alQK3J LXpWa+JyU8yYOSGUYIV8KAzfuBjKYEPzEHksOAsqlVaiBvc8IfR5BYX/TnltENYiD9gf GreHDCifVSV55WKWqa8nBYQIDbVu0phsWIt1/DuuT5AxOT6lxiXTmiTZ+e3KR7UNV+8F qMdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VCRo0o5R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si23199261ioo.75.2021.07.06.04.20.35; Tue, 06 Jul 2021 04:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VCRo0o5R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233371AbhGFLWd (ORCPT + 99 others); Tue, 6 Jul 2021 07:22:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:55612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232711AbhGFLS7 (ORCPT ); Tue, 6 Jul 2021 07:18:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 63D0A61C37; Tue, 6 Jul 2021 11:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570181; bh=Urdi0RMyDw7osxiomLrzAYzglhIWs81NXDgqg0/pm+w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VCRo0o5R04MKzMqq7RIzMURtSPrD7/0pVqMCp8RnL7hnZs5dWmQ7EBon7/DY9F35+ MBQH9QnZJd++zWO4rRjVPpAkT4Ml4HUc3H6ZLlOC0rEl0XVQ8JsthNKaC+a2/91uUm mBL71d9/a8V0b9eT3oyPoDlXbTb8LkKxQ/NSLUsNskhw2VCl0jNxysUOoI5kOEOgej IK1aqBl5fHraKvKRLb1VgYKufgy9q9wPppfkUXCyF+3rOevvIs2OAVwiTq7ZGHjJn5 4FCBquazsIXsQ4ZSIaqilrQg4XZWMY2cIQNnFTAh6HV4v1dfZ8sI34XYIPt0Qu5EKD vLDL980QHSQtA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , "David S . Miller" , Sasha Levin , linux-mips@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.13 097/189] net: sgi: ioc3-eth: check return value after calling platform_get_resource() Date: Tue, 6 Jul 2021 07:12:37 -0400 Message-Id: <20210706111409.2058071-97-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706111409.2058071-1-sashal@kernel.org> References: <20210706111409.2058071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit db8f7be1e1d64fbf113a456ef94534fbf5e9a9af ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 6eef0f45b133..2b29fd4cbdf4 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -835,6 +835,10 @@ static int ioc3eth_probe(struct platform_device *pdev) int err; regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!regs) { + dev_err(&pdev->dev, "Invalid resource\n"); + return -EINVAL; + } /* get mac addr from one wire prom */ if (ioc3eth_get_mac_addr(regs, mac_addr)) return -EPROBE_DEFER; /* not available yet */ -- 2.30.2