Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4571956pxv; Tue, 6 Jul 2021 04:21:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdePl5YP3bfIQtLqYfDX/UbbYgCWQgMZOl8ySudVhbPGmz706agrWN9Dhd5Jjqfa+K7niX X-Received: by 2002:a5d:8154:: with SMTP id f20mr15499463ioo.89.1625570481713; Tue, 06 Jul 2021 04:21:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625570481; cv=none; d=google.com; s=arc-20160816; b=wVLZopl3ghJjWKgadwTVoD+j7a+Zr1QASmYUgN791TrtNO1A6zBem5oiYhLdv/4g/i SblxVxbtBenPvtUujodRfox1+uaTVGJqUwb71aLVd79fyv9H02MDQXZ30nrlEc3KMjR4 guDVgWf9TiRuvHKzgijzoz8Imj1URCtP2U9OO15+adMAkbZlV29UqkqEk9W+VRB1o7YP 80XM7JQQSIJJDWU48EIO5o4GFVrfNd6HFbdQ5Z6BtPdpJlPt9D9M6bW+Dq+lN6nGAUUn 1qvCgA/mqbU3SiAARo3zpIQ2LnUB+mzV3vHPe3GhlmwjyZGNab1jlgdMANo1BVufsBaC 7j8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hq6imGZmpwN55xfSivFnnUGBb901pNuQBtVNjpchNEw=; b=VwdCib6aYRBpZ51cUugkbh82XAkRfn6oQPrUPcO1FOH973q3Wf/GYUi62kjixjCC5I RuXA8gTbkfcBIQj4/VRXeiiDMm9+79CiZeXvF4BaMtAoZ/4QBo8HSzCXw2HUykmKTNcG dmbLt3P1a7zSg36BWn4zTAdeHcWe62ndux67n0/63GpScgZLuByNdyRrR860/RGH09wT 32dL9ltmT0qGFLH2+9NwP4vrLG3nSRuqxJCcL2rLPwW5UAprdWMkGFtNqA7AvtNLQXps yzkmhlv2SBajJ+KVo/z4R4n89WL1MxJMUX4LW9sIQXhgOcnthdnjKiegPbVgqrkb4Y2n 5Xuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=enFms4T1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si4200015ioc.20.2021.07.06.04.21.09; Tue, 06 Jul 2021 04:21:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=enFms4T1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233986AbhGFLXR (ORCPT + 99 others); Tue, 6 Jul 2021 07:23:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:55802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232758AbhGFLTF (ORCPT ); Tue, 6 Jul 2021 07:19:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 735BC61C4C; Tue, 6 Jul 2021 11:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570187; bh=5TOr71VUDOiqYVGvZq2pvb41l1QmDcVK6CxhXV/U/8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=enFms4T1IPeN9lTcyMGxUR/7lggBnypnlKznvJ4HKDPnhJr08MxP63i0HD652uXsW /dNN4hYdm5kFXIW+v6nKfPyzFNJaqaCx1U0j4xWfPlayQwApbIiTFfawj+ewkZslri /RRN04b0AGVXeTlJXPj6r7z2OR9HYIAeT5+IpkgYySksLUL7kFiMROXnZ4ehFLHovb ds/UguvBfR3xKgcVd2YmRfnWhC0tbCJIucJX/Q4rfolUPp7HsXdRz08YcQhuBG41Te /YwMdp8E6ZbD59MFT3MMJV2Ae1yVF3t1Nhb9DmOmFK7HEiA3Mey9fR9yJpH/1zLMmO uRSi35OfDs1uQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Heiner Kallweit , Koba Ko , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.13 102/189] r8169: avoid link-up interrupt issue on RTL8106e if user enables ASPM Date: Tue, 6 Jul 2021 07:12:42 -0400 Message-Id: <20210706111409.2058071-102-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706111409.2058071-1-sashal@kernel.org> References: <20210706111409.2058071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit 1ee8856de82faec9bc8bd0f2308a7f27e30ba207 ] It has been reported that on RTL8106e the link-up interrupt may be significantly delayed if the user enables ASPM L1. Per default ASPM is disabled. The change leaves L1 enabled on the PCIe link (thus still allowing to reach higher package power saving states), but the NIC won't actively trigger it. Reported-by: Koba Ko Tested-by: Koba Ko Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/r8169_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 2ee72dc431cd..a0d4e052a79e 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -3510,7 +3510,6 @@ static void rtl_hw_start_8106(struct rtl8169_private *tp) rtl_eri_write(tp, 0x1b0, ERIAR_MASK_0011, 0x0000); rtl_pcie_state_l2l3_disable(tp); - rtl_hw_aspm_clkreq_enable(tp, true); } DECLARE_RTL_COND(rtl_mac_ocp_e00e_cond) -- 2.30.2