Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4576883pxv; Tue, 6 Jul 2021 04:28:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz42aiMt4Q1mzNKEis3OXtWzaQtvyteQWrWvaMPhhA+KAJa/DMT0DYN+Sdfp/wpOEyNxJ6z X-Received: by 2002:a02:7b22:: with SMTP id q34mr14999324jac.133.1625570925612; Tue, 06 Jul 2021 04:28:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625570925; cv=none; d=google.com; s=arc-20160816; b=sKT5a+phg9GPybhn7h/5EaVQHNkKodm8bejNePGLnwflUf0Su+yzWdZ1oooFfnTGNj VVIOyXVheb/tDSjWdQRqfIRbEGN++OpBELQ/fZBE1YEchK/4QEK8EIDzibcWTwtoQ9nY Y+HloowtoCIS+9fOqtf5bT8MoPLzBoxt4u18rVM9DX4njUOT/3yGCBuXfzwy1tJaYf6t uShNnHuWIw3gZ8AB95JE38TKsyHBiBI9S6S67zTN+8JVlyy0/jvTn80T9zxfwDlyRdnT 7NyFnIp6T8FLbFXP+GcowBEENgON1t/j+onxJzc1N8e+WZPDE9x2C1dCZNsHECgPk3b+ Fm6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7EjWe3WUyhWQIJjHPiAIGYeBfWuBDqzjS00iHBJKG08=; b=o/Isz0rWkYHd8DvCmxfitGHFhbA+MfW+iHN7xBi4VrcG61vhAw6As9Cxg08BYqCxkZ iYSvF+UvK8KQJfNpn5VHkmJLykKihZz4qwBT03uJsYNFUBy7toa+Ltb8+Fder7SqmeSQ gL4itr8A9kfqI1U6DiVhdT23YgVFh/aub9RGzidbp/if/Wpl7QtqkStGn1oLBmeLvuxn sSmhdEnvuiSaGhRFjoF1IclQpPhupGN7cGuzTpNA7mMUajAZWZRX0eJEDML341qwfaOn Zwi94QBTwC9TOFSjBxggy+LvEtxZMxZh5epltgOJ2Jtyb+ibKwuZG7AA3Raibflk4+hu sUxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LUn5bbWa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c4si16239134ilk.14.2021.07.06.04.28.33; Tue, 06 Jul 2021 04:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LUn5bbWa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232321AbhGFLag (ORCPT + 99 others); Tue, 6 Jul 2021 07:30:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:53338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbhGFLR4 (ORCPT ); Tue, 6 Jul 2021 07:17:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F262E61C4E; Tue, 6 Jul 2021 11:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570117; bh=dU+sE3O5fFtWgS0WL4SVp5dHsvS6LMM2bVi73Rk4nhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LUn5bbWaVY7ZKRelAs9Kih61xigz2UQckC11wJVcwk/a37LigAmTFBiyFHASCBgYz fGaRMRsMY3XUdL4vrZ010Rq/zK5SQpMs2mDISQ6oFfvrC3K8n9/NxqIqdVdDRcKcSQ Go7/Qt0kTutsCrXXPRyAvfRdW2DrGetDgvZTsuxhGbSySHVT8whw01swK3Ik3r31dE WiEFMbTewrDAG4GYM+Zaozz6r6Z6Jc4CC8s7hR7cIXw58vk1PJksReRmD50Y1UIe6O r9vPNpaHda9SwIDVU4eFy8fS9dPPt70VAcjWedlLJtRvRrMD7be1wphfO1t29gXhMV TaCwzUjiaLFlw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zou Wei , Hulk Robot , Robert Foss , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.13 048/189] drm/bridge: cdns: Fix PM reference leak in cdns_dsi_transfer() Date: Tue, 6 Jul 2021 07:11:48 -0400 Message-Id: <20210706111409.2058071-48-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706111409.2058071-1-sashal@kernel.org> References: <20210706111409.2058071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zou Wei [ Upstream commit 33f90f27e1c5ccd648d3e78a1c28be9ee8791cf1 ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Zou Wei Reviewed-by: Robert Foss Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/1621840862-106024-1-git-send-email-zou_wei@huawei.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index 76373e31df92..b31281f76117 100644 --- a/drivers/gpu/drm/bridge/cdns-dsi.c +++ b/drivers/gpu/drm/bridge/cdns-dsi.c @@ -1028,7 +1028,7 @@ static ssize_t cdns_dsi_transfer(struct mipi_dsi_host *host, struct mipi_dsi_packet packet; int ret, i, tx_len, rx_len; - ret = pm_runtime_get_sync(host->dev); + ret = pm_runtime_resume_and_get(host->dev); if (ret < 0) return ret; -- 2.30.2