Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4615698pxv; Tue, 6 Jul 2021 05:23:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGSHJqne/jja9NyCHSFXaW/AIvRhp4O+fcKPlcD2We/8gqXrIuKjYLO5J+pPkdkNdalMpy X-Received: by 2002:aa7:c7c2:: with SMTP id o2mr22925469eds.166.1625574105172; Tue, 06 Jul 2021 05:21:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625574105; cv=none; d=google.com; s=arc-20160816; b=iZW0ptMTPZgqbP23hXirIo8hGLPHWCUQYSAU2QTcNjA8EtQnSfNLZ1OMhJB1kvirGu y10XITqUuNZPfFOaQed4+yivhPO12CjpfFv792jZ95CK0kcVRNlCTEW0VRGg6Em4NqNT uBPrslw7ELCsTKy3j6660JbF9Lxrn8C5b1AGVITWP+thbUOMYkiV3H4oBOJKaX1eHJyD dNOaIPZnDtES1sSvBk0M2N+fNL3QPwBzRLCZTr+ucSrXWD3rvvNc6OcK3zw2C2i1tA6y n2X63dR/+/c8WqEA8Loj/K7lxoq5ummNOFZMmZmk5PBDaQgzdMS+vtT25sBm0FIEw7Yg MnHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=X2A32BxhYnj2+Pm74HLdF8g/xPOgvJM+hgEzhr6mHmk=; b=G/AMrJ4EK3nCITP100JTcaMYkokCRS8xF5TqCuyCoSgbrAsVfR9UqXCYwjWv0/fnXt zqgg+MPJgx+zN0Cq2GgJsccEmXV0cijbWpablTLpVRHDB1TO35YJRqVC+tbtoonf8fVQ BNKesDAaSSM1Br8NqIVZHtXLO3BI4hYkBfRq1upDYojB4B1c7MRV9FoK6b6spsYn2VUJ 4vCQhDjzJtpnGzYpUy+n7w7qgfv28rodRyFcMeSADZmU2hK1hXR3/K1qYccbrf/EeHEM Rq0Gs67FYJpzZ8cSSz+8ezC7ckvx89a2sd3pGp7Br5qjhpec/tu0wRGXpyiw3rP+iGeg ybOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b2si14174877ejl.199.2021.07.06.05.21.21; Tue, 06 Jul 2021 05:21:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231787AbhGFMWK (ORCPT + 99 others); Tue, 6 Jul 2021 08:22:10 -0400 Received: from foss.arm.com ([217.140.110.172]:39928 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243070AbhGFMDP (ORCPT ); Tue, 6 Jul 2021 08:03:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9D411FB; Tue, 6 Jul 2021 05:00:34 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.31.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B83D3F73B; Tue, 6 Jul 2021 05:00:33 -0700 (PDT) Date: Tue, 6 Jul 2021 13:00:30 +0100 From: Mark Rutland To: Anatoly Pugachev , Peter Zijlstra Cc: Linux Kernel list , Sparc kernel list , debian-sparc Subject: Re: [sparc64] locking/atomic, kernel OOPS on running stress-ng Message-ID: <20210706120030.GB69200@C02TD0UTHF1T.local> References: <20210705195638.GA53988@C02TD0UTHF1T.local> <20210706091104.GA69200@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021 at 02:51:06PM +0300, Anatoly Pugachev wrote: > On Tue, Jul 6, 2021 at 12:11 PM Mark Rutland wrote: > > Fixes: ff5b4f1ed580c59d ("locking/atomic: sparc: move to ARCH_ATOMIC") > > Signed-off-by: Mark Rutland > > Reported-by: Anatoly Pugachev > > Cc: "David S. Miller" > > Cc: Peter Zijlstra > > --- > > arch/sparc/include/asm/cmpxchg_64.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/sparc/include/asm/cmpxchg_64.h b/arch/sparc/include/asm/cmpxchg_64.h > > index 8c39a9981187..12d00a42c0a3 100644 > > --- a/arch/sparc/include/asm/cmpxchg_64.h > > +++ b/arch/sparc/include/asm/cmpxchg_64.h > > @@ -201,7 +201,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr, > > #define arch_cmpxchg64_local(ptr, o, n) \ > > ({ \ > > BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ > > - cmpxchg_local((ptr), (o), (n)); \ > > + arch_cmpxchg_local((ptr), (o), (n)); \ > > }) > > #define arch_cmpxchg64(ptr, o, n) arch_cmpxchg64_local((ptr), (o), (n)) > > > Mark, thanks, fixed... > tested on git kernel 5.13.0-11788-g79160a603bdb-dirty (dirty - cause > patch has been applied). Great! Thanks for confirming. Peter, are you happy to pick that (full commit in last mail), or should I send a new copy? Thanks, Mark.