Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Jul 2021 16:44:25 +0200
From:   Stefano Garzarella <sgarzare@redhat.com>
To:     Eugenio =?utf-8?B?UMOpcmV6?= <eperezma@redhat.com>
Cc:     mst@redhat.com, linux-kernel@vger.kernel.org,
        Matthew Wilcox <willy@infradead.org>,
        Jason Wang <jasowang@redhat.com>,
        Yunsheng Lin <linyunsheng@huawei.com>
Subject: Re: [PATCH 2/2] vringh: Include spinlock.h
Message-ID: <20210706144425.cp3yzdinmosqftjr@steredhat>
References: <20210706142632.670483-1-eperezma@redhat.com>
 <20210706142632.670483-3-eperezma@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210706142632.670483-3-eperezma@redhat.com>
Precedence: bulk

On Tue, Jul 06, 2021 at 04:26:32PM +0200, Eugenio P?rez wrote:
>Commit f53d9910d009 ("vringh: add 'iotlb_lock' to synchronize iotlb
>accesses") introduces this dependency, but does not include spinlock.h.
>While kernel seems to compile as usual, tools/virtio cannot do the
>same.
>
>Fixes: f53d9910d009 ("vringh: add 'iotlb_lock' to synchronize iotlb accesses")
>
>Signed-off-by: Eugenio P?rez <eperezma@redhat.com>
>---
> include/linux/vringh.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/linux/vringh.h b/include/linux/vringh.h
>index 84db7b8f912f..212892cf9822 100644
>--- a/include/linux/vringh.h
>+++ b/include/linux/vringh.h
>@@ -14,6 +14,7 @@
> #include <linux/virtio_byteorder.h>
> #include <linux/uio.h>
> #include <linux/slab.h>
>+#include <linux/spinlock.h>
> #if IS_REACHABLE(CONFIG_VHOST_IOTLB)
> #include <linux/dma-direction.h>
> #include <linux/vhost_iotlb.h>
>-- 
>2.27.0
>

Ooops, thanks for fixing this!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>