Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [irqchip: irq/irqchip-next] irqdomain: Protect the linear revmap
 with RCU
To:     Marc Zyngier <maz@kernel.org>
Cc:     linux-kernel@vger.kernel.org, tglx@linutronix.de
References: <162341967699.19906.3242958007782554792.tip-bot2@tip-bot2>
 <20210705172352.GA56304@roeck-us.net> <87h7h88wsd.wl-maz@kernel.org>
 <79ec0069-553b-cac1-5ec7-d68c757619a5@roeck-us.net>
 <87fsws8uty.wl-maz@kernel.org>
 <fb3b9223-a811-af48-ead5-b2c6f7305de4@roeck-us.net>
 <87eecb94mq.wl-maz@kernel.org>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <f24c29d3-ee7f-651b-6399-a1e7b5ed073f@roeck-us.net>
Date:   Tue, 6 Jul 2021 07:23:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <87eecb94mq.wl-maz@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/6/21 2:24 AM, Marc Zyngier wrote:
> On Mon, 05 Jul 2021 21:36:36 +0100,
> Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 7/5/21 11:43 AM, Marc Zyngier wrote:
> 
>>> It definitely helps, and confirms my hunch. With the patch below, I'm
>>> not getting the warnings anymore. I'm pretty sure a number of other
>>> MIPS systems suffer from similar issues, which I'll address similarly.
>>>
>>> Please let me know if that addresses the issue on your end.
>>>
>>
>> Yes, it does. Feel free to add
>>
>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>
>> to the real patch.
> 
> Thanks.
> 
>> Now the big question: Why does this only affect 32-bit little endian
>> mips images, but not the matching big endian images, nor 64-bit images ?
> 

Actually they do.

> Are you sure these images are using the exact same HW? A bunch (most?)
> of MIPS systems do not use irqdomains in their root interrupt
> handling, so this issue wouldn't be visible (irq_enter() will already
> have been done for the chained interrupt handling).
> 
> FWIW, I can reproduce the problem by switching your mipsel config to
> BE, and adding this patch fixes it.
> 

Yes, turns out I did not have the necessary debugging options enabled
in my other mips tests.

Thanks,
Guenter