Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4747307pxv; Tue, 6 Jul 2021 08:13:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKvKCy1yCZZAVxuxX2wvCoDB4uOwtJPgOVGXmf2SYCjRAlgLyxJx6ZFlXyU7dRRGibkNWj X-Received: by 2002:a92:6605:: with SMTP id a5mr15565733ilc.15.1625584431939; Tue, 06 Jul 2021 08:13:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625584431; cv=none; d=google.com; s=arc-20160816; b=ss0GvjDlCCqyJQdt019cWNAamZuxT8GevS5BEFSLoi0aBJLPDzlZDVz6uWOJtlLzGl G4mw2RHtEGRf30nlhF9TD0uGfuvsbsF3+AgkRM47aOo2ykBoUFg/lEG3yEfocZlHHbFc e2O9XrK2YbItZX63jD5mVl5CzCyU71gygy/UGQm3NaBJ4MTHOWIXP815Q+onlj09hBub sdpjPPgQ5cIECiXqWO9Xb6Rxk27khZt9sQJXolxVs+OZ9HE6qazR856kOCdZ3XV4DJTV G2Jr9k4GkWAu/ePLYmiW/hPBTMASycAqaG7JPOOwsmezK1xmFrrMbzEqUhmfOVgqrE+9 yOjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from; bh=EebiqBrZuTjqJlxzyEtGU2Z/P2VqBv3ehMQMlIA/rz8=; b=y50pVBCbNkNLGc5IznTycFHSAAeY+OBuh+Z0XJqsP0/K7/qH92nwMejY9TWEdT73+3 yl6yH/A9xEJ4gP02IBeoibyaLh6ZpFg96xM8NnUwDuL/neuvPImWX92qAjOhFdoKULcm Z7EfftAaEdyV2fH3rdl3a4SMd1yDMwvIqtvalj1jFWOMg9vKcnKg1aN/4RkmQcWWT9I2 mumCsw3h6Pn0HNpMCIXayjkapAACEJdOlf5vCqdU0V5qu/E84m2+64xeF51euiLiPFcN sFvYxWIh7teuf61FaqbkHTMaAJpQwOjMxCAmlcL5npIIqS/fvXKW4D6yihOvlpwKjgqZ is0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si18349005iol.103.2021.07.06.08.13.40; Tue, 06 Jul 2021 08:13:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232039AbhGFPPW convert rfc822-to-8bit (ORCPT + 99 others); Tue, 6 Jul 2021 11:15:22 -0400 Received: from mga11.intel.com ([192.55.52.93]:50837 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbhGFPPS (ORCPT ); Tue, 6 Jul 2021 11:15:18 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="206123662" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="206123662" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 08:12:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="427618041" Received: from um.fi.intel.com (HELO um) ([10.237.72.62]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2021 08:12:00 -0700 From: Alexander Shishkin To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?utf-8?Q?Rafa=C5=82_Mi=C5=82eck?= =?utf-8?Q?i?= , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov , Ulf Hansson , Lee Jones , Tomas Winkler , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , Jon Mason , Allen Hubbe , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84sk?= =?utf-8?Q?i?= , Bjorn Helgaas , Dominik Brodowski , Maximilian Luz , Hans de Goede , Mark Gross , Matt Porter , Alexandre Bounine , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Thorsten Scherer , Srinivas Kandagatla , Andy Gross , Mark Brown , Stephen Boyd , Michael Buesch , Sven Van Asbroeck , Johan Hovold , Alex Elder , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Rob Herring , Jiri Slaby , Heikki Krogerus , "Michael S. Tsirkin" , Jason Wang , Kirti Wankhede , Alex Williamson , Cornelia Huck , Martyn Welch , Manohar Vanga , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Johannes Berg , Jaroslav Kysela , Takashi Iwai , Marc Zyngier , Tyrel Datwyler , Vladimir Zapolskiy , Samuel Holland , Qinglang Miao , Alexey Kardashevskiy , Kai-Heng Feng , Joey Pabalan , Pali =?utf-8?Q?Roh=C3=A1r?= , Adrian Hunter , Frank Li , Mike Christie , Bodo Stroesser , Hannes Reinecke , David Woodhouse , SeongJae Park , Julien Grall , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, alexander.shishkin@linux.intel.com Subject: Re: [PATCH] bus: Make remove callback return void In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Date: Tue, 06 Jul 2021 18:11:59 +0300 Message-ID: <87eecbjx34.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Uwe Kleine-König writes: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König FWIW, the intel_th bit is Acked-by: Alexander Shishkin