Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/)
To:     Wei Liu <wei.liu@kernel.org>
Cc:     linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mikelley@microsoft.com,
        viremana@linux.microsoft.com, sunilmut@microsoft.com,
        vkuznets@redhat.com, ligrassi@microsoft.com, kys@microsoft.com
References: <1622241819-21155-1-git-send-email-nunodasneves@linux.microsoft.com>
 <1622241819-21155-4-git-send-email-nunodasneves@linux.microsoft.com>
 <20210627120004.u4pn3stgcny2zl4i@liuwe-devbox-debian-v2>
From:   Nuno Das Neves <nunodasneves@linux.microsoft.com>
Message-ID: <c88d08ee-b559-f1a3-b53c-d740f60273e3@linux.microsoft.com>
Date:   Tue, 6 Jul 2021 08:41:03 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210627120004.u4pn3stgcny2zl4i@liuwe-devbox-debian-v2>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/27/2021 5:00 AM, Wei Liu wrote:
> On Fri, May 28, 2021 at 03:43:23PM -0700, Nuno Das Neves wrote:
> [...]
>> +
>> +static int
>> +__init mshv_init(void)
>> +{
>> +	int ret;
> 
> Please check if Linux is running on Microsoft Hypervisor here. If not,
> this module should not be loaded.
> 
> Something like:
> 
>        if (!hv_is_hyperv_initialized())
>                return -ENODEV;

Good point - will do.

> 
> Wei.
>