Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Jul 2021 16:51:31 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Matteo Croce <mcroce@linux.microsoft.com>
Cc:     Yunsheng Lin <linyunsheng@huawei.com>, mw@semihalf.com,
        Sven Auhagen <sven.auhagen@voleatech.de>, davem@davemloft.net,
        kuba@kernel.org, linuxarm@openeuler.org, yisen.zhuang@huawei.com,
        salil.mehta@huawei.com, thomas.petazzoni@bootlin.com,
        hawk@kernel.org, ilias.apalodimas@linaro.org, ast@kernel.org,
        daniel@iogearbox.net, john.fastabend@gmail.com,
        akpm@linux-foundation.org, peterz@infradead.org, will@kernel.org,
        willy@infradead.org, vbabka@suse.cz, fenghua.yu@intel.com,
        guro@fb.com, peterx@redhat.com, feng.tang@intel.com, jgg@ziepe.ca,
        mcroce@microsoft.com, hughd@google.com, jonathan.lemon@gmail.com,
        alobakin@pm.me, willemb@google.com, wenxu@ucloud.cn,
        cong.wang@bytedance.com, haokexin@gmail.com, nogikh@google.com,
        elver@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next RFC 0/2] add elevated refcnt support for page
 pool
Message-ID: <20210706155131.GS22278@shell.armlinux.org.uk>
References: <1625044676-12441-1-git-send-email-linyunsheng@huawei.com>
 <20210702153947.7b44acdf@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210702153947.7b44acdf@linux.microsoft.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Fri, Jul 02, 2021 at 03:39:47PM +0200, Matteo Croce wrote:
> On Wed, 30 Jun 2021 17:17:54 +0800
> Yunsheng Lin <linyunsheng@huawei.com> wrote:
> 
> > This patchset adds elevated refcnt support for page pool
> > and enable skb's page frag recycling based on page pool
> > in hns3 drvier.
> > 
> > Yunsheng Lin (2):
> >   page_pool: add page recycling support based on elevated refcnt
> >   net: hns3: support skb's frag page recycling based on page pool
> > 
> >  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c    |  79 +++++++-
> >  drivers/net/ethernet/hisilicon/hns3/hns3_enet.h    |   3 +
> >  drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c |   1 +
> >  drivers/net/ethernet/marvell/mvneta.c              |   6 +-
> >  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c    |   2 +-
> >  include/linux/mm_types.h                           |   2 +-
> >  include/linux/skbuff.h                             |   4 +-
> >  include/net/page_pool.h                            |  30 ++-
> >  net/core/page_pool.c                               | 215
> > +++++++++++++++++---- 9 files changed, 285 insertions(+), 57
> > deletions(-)
> > 
> 
> Interesting!
> Unfortunately I'll not have access to my macchiatobin anytime soon, can
> someone test the impact, if any, on mvpp2?

I'll try to test. Please let me know what kind of testing you're
looking for (I haven't been following these patches, sorry.)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!