Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4776392pxv; Tue, 6 Jul 2021 08:54:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkGWKxvnvsYf1rwUg6Rb98gyu7jy60cXcYUfSxI/NJPvSrbf3Zpt0Yydm9EsOVTfXRXes2 X-Received: by 2002:a17:906:2844:: with SMTP id s4mr19229974ejc.263.1625586861700; Tue, 06 Jul 2021 08:54:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625586861; cv=none; d=google.com; s=arc-20160816; b=NwH2Qi70nASN52+VTYRST87YuHadyNXdIPdV4TPFg6jJ6HGNEyaTX1Zga9tXt+MpUo gF1mz7wYoOEvxvkQGzN4rJ+Zsyq1keaxFqBORVbyvApPFRSYcSQLCR0yD1hPSTsZG60e xZnzpgHYeAImKxxvs/8slfjcJ0f/rbhSVSdUH5i1diWyhEaofJxQ6a1wypxbWjhW0Btn hYtjZEr5/zDCT+Flsjb9dc05YNbsyje0Xvts1AoR8RohL/EPO1L0S1inkMP+yzPrJCs/ B+aPOMbS2apXDKWTldm2YlpQd5i2Y2Av7bsXGMOABtZnJB2t64fus7FHrVgJpW/t9HuM g7zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DEoMLuCwlkxIBKpWQQueyqoJCFow5k/eUgcTd2M6kGE=; b=P8iiKC1sl8CZRhv+8m6Ch6Y/EVxkWqQ4EyNEry6VnlnvhCByT/sjGKmy000TSSzIzx Wzu7Ct/Aew0671z5D1gzxxmWhCmwokCBC2hgL1b45ON1l28kPSNKlU0JaPPjn3RmK80l 8UYwRc3cgJMxkFrHTIPiY/CuceusAaWaYcLVAU5VqQAIDaVC1hOfLU6FM2pQTc69zjWK s99VvbTvjSF8gT9qGXx1Jge5dgJn50DhYhXEHQ/B6/pghk51AkRTh023E3VwwLMmapt6 7pEA9U43UTtyvcs9/INqDyxS9jDAsWTzsBSz2vKs82YVMieGxVdOBbnbzK5nG1Oq8v8t zsZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si18307558edj.74.2021.07.06.08.53.58; Tue, 06 Jul 2021 08:54:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbhGFPz0 (ORCPT + 99 others); Tue, 6 Jul 2021 11:55:26 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:40385 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232658AbhGFPzZ (ORCPT ); Tue, 6 Jul 2021 11:55:25 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0nL8-0007mP-BH; Tue, 06 Jul 2021 17:50:26 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m0nL6-0005Sp-Bm; Tue, 06 Jul 2021 17:50:24 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: kernel@pengutronix.de, Cornelia Huck , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] s390/ccwgroup: Drop if with an always false condition Date: Tue, 6 Jul 2021 17:48:01 +0200 Message-Id: <20210706154803.1631813-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver core only calls a bus remove callback when there is a driver. So dev->driver is never NULL and the check can safely be removed. Signed-off-by: Uwe Kleine-König --- drivers/s390/cio/ccwgroup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c index 9748165e08e9..a6aeab1ea0ae 100644 --- a/drivers/s390/cio/ccwgroup.c +++ b/drivers/s390/cio/ccwgroup.c @@ -444,8 +444,6 @@ static int ccwgroup_remove(struct device *dev) struct ccwgroup_device *gdev = to_ccwgroupdev(dev); struct ccwgroup_driver *gdrv = to_ccwgroupdrv(dev->driver); - if (!dev->driver) - return 0; if (gdrv->remove) gdrv->remove(gdev); -- 2.30.2