Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4786659pxv; Tue, 6 Jul 2021 09:07:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwESSXECbjwmcvKLaz6tleyGEPtQzMAN8y/+0vZdhEdEb8aSK517urtc3EfyEq4bfe4gKOU X-Received: by 2002:aa7:dd1a:: with SMTP id i26mr23889203edv.339.1625587644007; Tue, 06 Jul 2021 09:07:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625587644; cv=none; d=google.com; s=arc-20160816; b=SyJeXyorFOFk3UaV2cQMSysMnUMq8Ew5cOiXGk+UJO6PMMVl+ZIBHqQaXjkchL/PMN ZPtEVv1vSpfYCSq9LKVF1nuH60b3u05XZfP5tjJ6KV1pTqhjxirYFiHNA7hXc9vYaugn bebhRPIjb8vvHm1XAdu8Y7el4Kk8f345G1FQLQIgvnxrgqKFWEkGpLA1A+1J7BSA1A4U YZr/E5K+ztvqDcHx3wkqarNAOxog67AsUu76lXTer1fRYjUqTBibnkJBgmG5HjEpNBQa C16IdDQJbKMwF0LR5P9GWKgT8PtH7F7wfXk6guK2l1O3KoqtvTHWAptA5dKgQyc4K8x9 h4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=CQGQgHOzZjV+IDWSk2JT0vs72mmDhHvW+IPACB4voLk=; b=DBXxCIUxmy5JUdUVF+3WgayG8tR1Mh1unQkAzuSC9TvuGTjZvLwsngzL0y8rjYxc/z XT9nZnPe5AkpHT9S4QTZ0QVygMB+Emneg1dHKpFdclRGzlfudWEHPFzFmUgyfu3j4ZM4 MrLNh73GhVhOtvZGu/znZfIGaV/dugja2o1qJ+IzGy4mHdyg7JCIPDZ4HsFXAQJB8SHh 1Zmya57PFSiWu7h4UaoMb2/9h+y6TD/gUA53xAUZ2wBPShJ4prcu5ZP8svKRrgRRsel5 OpMIOS9l11L4hsGj6ngAMe094bO2BZSxddtF+A0W3jQg0H7pFrpNqtBBlVj7E+HouFE8 QgjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jy1si16383972ejc.592.2021.07.06.09.06.57; Tue, 06 Jul 2021 09:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbhGFQIk (ORCPT + 99 others); Tue, 6 Jul 2021 12:08:40 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:34695 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhGFQIk (ORCPT ); Tue, 6 Jul 2021 12:08:40 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0na9-0001Xn-Na; Tue, 06 Jul 2021 18:05:57 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m0na9-0007ty-5i; Tue, 06 Jul 2021 18:05:57 +0200 Date: Tue, 6 Jul 2021 18:05:43 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Cornelia Huck Cc: Greg Kroah-Hartman , linux-s390@vger.kernel.org, Eric Farman , kernel@pengutronix.de, Vasily Gorbik , Heiko Carstens , Peter Oberparleiter , linux-kernel@vger.kernel.org, Halil Pasic , Christian Borntraeger , Vineeth Vijayan , kvm@vger.kernel.org, Matthew Rosato Subject: Re: [PATCH v2 1/4] s390/cio: Make struct css_driver::remove return void Message-ID: <20210706160543.3qfekhzalwsrtahv@pengutronix.de> References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-2-u.kleine-koenig@pengutronix.de> <87zguzfn8e.fsf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bqb4qgmhkapjyrom" Content-Disposition: inline In-Reply-To: <87zguzfn8e.fsf@redhat.com> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bqb4qgmhkapjyrom Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 06, 2021 at 05:58:25PM +0200, Cornelia Huck wrote: > On Tue, Jul 06 2021, Uwe Kleine-K=F6nig = wrote: >=20 > > The driver core ignores the return value of css_remove() > > (because there is only little it can do when a device disappears) and > > there are no pci_epf_drivers with a remove callback. >=20 > s/pci_epf/css/ Argh, too much copy&paste. I make this: The driver core ignores the return value of css_remove() (because there is only little it can do when a device disappears) and all callbacks return 0 anyhow. to make this actually correct. > Reviewed-by: Cornelia Huck Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --bqb4qgmhkapjyrom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDkf1MACgkQwfwUeK3K 7AnBiQf8D47hxJyNZj9iLEgV5cF5XI5NaUQkYuyP8DFRJsSKUmmHVkpbjebqvShn IsZyUlhkVZMz/+sm7b7WLx8flFcRwktqMzF4qVveu3oj+VU6gENlMhWWzhjLaRp/ GpoUGx4Wb5WowhHxemhm6pQ5xl67Ybx6AWwZdpgmwfBbjOEepqcp5CJKUMFxrPSq eKputuI68l7SRfCkN5WfCsWcU++tBYiFeuI9b5txBJ+J2uf6sTX+5qHnJ+xj9H+M xHog8O2wezn8Mia+0VNwsnyEx1uuivH1qXcLEvEjQCqOAjmwLiQfrUbt0cHMqYL2 6IHjEFCLSb4UWm1t4CaI7HFLcJPdOg== =upS2 -----END PGP SIGNATURE----- --bqb4qgmhkapjyrom--