Date: Wed, 15 Nov 2006 16:28:09 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Phillip Susi <psusi@cfl.rr.com>
Cc: Tejun Heo <htejun@gmail.com>, Mathieu Fluhr <mfluhr@nero.com>,
       Arjan van de Ven <arjan@infradead.org>, jgarzik@pobox.com,
       linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: READ SCSI cmd seems to fail on SATA optical devices...
Message-ID: <20061115162809.3ecd7d3a@localhost.localdomain>
In-Reply-To: <455B3D99.8040705@cfl.rr.com>
References: <1163434776.2984.21.camel@de-c-l-110.nero-de.internal>
	<4558BE57.4020700@cfl.rr.com>
	<1163444160.27291.2.camel@de-c-l-110.nero-de.internal>
	<1163446372.15249.190.camel@laptopd505.fenrus.org>
	<1163519125.2998.8.camel@de-c-l-110.nero-de.internal>
	<455 <455B3A78.7010503@gmail.com>
	<455B3D99.8040705@cfl.rr.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 677
Lines: 17

On Wed, 15 Nov 2006 11:17:29 -0500
Phillip Susi <psusi@cfl.rr.com> wrote:

> The original patch memsets the entire buffer only to copy over most of 
> it right after.  Could you amend the patch so that it memcpys first, 
> then memsets only the remainder of the buffer?  No sense wasting cpu 
> cycles.

Look at the generated code - its faster to memset the entire CDB as Tejun
is doing than actually bother to think about it.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/