Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WIblwKlWmPODgDevCcx7j2OBYr0gaBHioLmRXgFPvzM3iU07m9iYSZY+mO2Q3R4aMcETDDzWg2
 1Qrkm/+VOpHrvbIVMIZ601kRQaMKVDY8o9ykfy98CEF0nZzqbwEsiHChBI4hZMpc7UM5sqRCSa
 Ivd5AgFHCUKb/gIyaagXTs13SnbiKQyHS0TEkj3N91VJRM+AYgb9Q5lUzrViq8QCBvItAxIwsA
 78f3QOIDjNo7F+DDNhqBMvM9pC5zwtN6HPcX9n7xNV1TrwYGxotIN1mrXHXRchTopozRUkyuy4
 1pY=
From:   Don Brace <don.brace@microchip.com>
To:     <hch@infradead.org>, <martin.peterson@oracle.com>,
        <jejb@linux.vnet.ibm.com>, <linux-scsi@vger.kernel.org>
CC:     <Kevin.Barnett@microchip.com>, <scott.teel@microchip.com>,
        <Justin.Lindley@microchip.com>, <scott.benesh@microchip.com>,
        <gerry.morong@microchip.com>, <mahesh.rajashekhara@microchip.com>,
        <mike.mcgowen@microchip.com>, <murthy.bhat@microchip.com>,
        <balsundar.p@microchip.com>, <joseph.szczypek@hpe.com>,
        <jeff@canonical.com>, <POSWALD@suse.com>,
        <john.p.donnelly@oracle.com>, <mwilck@suse.com>,
        <pmenzel@molgen.mpg.de>, <linux-kernel@vger.kernel.org>
Subject: [smartpqi updates  PATCH 2/9] smartpqi: rm unsupported controller features msgs
Date:   Tue, 6 Jul 2021 13:16:11 -0500
Message-ID: <20210706181618.27960-3-don.brace@microchip.com>
In-Reply-To: <20210706181618.27960-1-don.brace@microchip.com>
References: <20210706181618.27960-1-don.brace@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

From: Kevin Barnett <kevin.barnett@microchip.com>

Remove "Feature XYZ not supported by controller" messages.

During driver initialization, the driver examines the PQI Table Feature bits.
These bits are used by the controller to advertise features supported by the
controller. For any features not supported by the controller, the driver would
display a message in the form:
        "Feature XYZ not supported by controller"
Some of these "negative" messages were causing customer confusion.

Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi_init.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index d977c7b30d5c..7958316841a4 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -7255,11 +7255,8 @@ struct pqi_firmware_feature {
 static void pqi_firmware_feature_status(struct pqi_ctrl_info *ctrl_info,
 	struct pqi_firmware_feature *firmware_feature)
 {
-	if (!firmware_feature->supported) {
-		dev_info(&ctrl_info->pci_dev->dev, "%s not supported by controller\n",
-			firmware_feature->feature_name);
+	if (!firmware_feature->supported)
 		return;
-	}
 
 	if (firmware_feature->enabled) {
 		dev_info(&ctrl_info->pci_dev->dev,
-- 
2.28.0.rc1.9.ge7ae437ac1