Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4963280pxv; Tue, 6 Jul 2021 13:38:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzHUgVEt4K8qK6SHec3AA1Mn++5QXMsV7nlskuxt7i2WIXjuyZDjTKFsUz8rymKDOzc162 X-Received: by 2002:a17:907:7b9f:: with SMTP id ne31mr5516499ejc.359.1625603908231; Tue, 06 Jul 2021 13:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625603908; cv=none; d=google.com; s=arc-20160816; b=XW5G1TVEEzJ8B7yHHk+oqC5vve3CmF2wEp4TXMR+rDh2w5KZVicJaReQNyOCKXGc2m cvlSaQmuRkkpD0tiyPdDZepSdkmM1CDNjJLTL84iZg+20wX7r0rf6Q4usd4GN1EV9Sbg VItFIaDMDPAiUjl4+O91XtTKHSU2d9wnBTHMIyVNJ12lkop2KyltmD2CnTCfx/vbj3eO Tw/Y/qqmVO+RXwb1oYvRz1/QlT7IJsooHa6+JE+eZ5eRNEXYs856NPGylwVX0hn5TVQD mye6Vd9M2tz5DWc9lcCwVf5hw9fac4jfcPSSNNDsv62LO6JPYid4G+q9hyzgAATwjwFI uIhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ICSJlQlSgTNd605M++v+mHZyBgX5QCDOQLTCW/JboK8=; b=1LWfLH9AdBzP+T9F0NpwO/kysh28EJdKR0H3MyXlgTbZoYx3Juv3O+7V9K23inDf2H EKsUrhG07+/7xfQCoC7DYlDHun/sAlo6+Dow3UlOVvgYr1j1bjX0YtXTsl6LTu6ODSdG +b/L+bSsregiCL1eZLe8rVyfBOtCtrTx+HEZTQqFHgOntl+kKaSbZxdFE0jqsRYz2mlP 2z6D+GLsAIHfJSQug4uUoJgHINBtHHKHh961S7RjH96WKG1NJOLoad2L5bIh7xVlvWbp E6Tite8k7gmdh8r9gI4EfvmoAF66iFjwj8W7MGYgBXYCWLPQaCIpIR16QolQpvXM+O9r ji6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx13si14706256edb.258.2021.07.06.13.38.03; Tue, 06 Jul 2021 13:38:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbhGFUhC (ORCPT + 99 others); Tue, 6 Jul 2021 16:37:02 -0400 Received: from mail-ej1-f49.google.com ([209.85.218.49]:45992 "EHLO mail-ej1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbhGFUhB (ORCPT ); Tue, 6 Jul 2021 16:37:01 -0400 Received: by mail-ej1-f49.google.com with SMTP id hc16so36206247ejc.12; Tue, 06 Jul 2021 13:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ICSJlQlSgTNd605M++v+mHZyBgX5QCDOQLTCW/JboK8=; b=RbdwTONsbKLLWtK3IFGKix+k9A7v7MKeqjuCEYRRQ2QcEE4nlJVD/eyWME0smJb/+G i4vrMfVMrKjyeOkVhk8Fg1KyYiTa9EA56+91IBZhDfwKZtqp6+eaaeqGyPNbnC9umDTN mB6H4wb8EpfydJhgfvm74kHMipypuQzsfqwId+8cmS4CpsCX0dsWwUpYQ6UJ83zIQ740 cLo3gSP7An0sKB8Ds8aP14033HqSsvImePV3/GqtN1I+DdKqDgBLoUGeBBkkjScVvkMx 70mJOufC4Jmxx0ORwZvAM8OoqzAznooQYnZrhSlitPW+X7G4ScMvsUALAUSHnCLbeI0I IOMQ== X-Gm-Message-State: AOAM533PGVB+ynXC2Q95KScdahL8AcLKVIdsxZHzLpaAJwfPFy2sEWCs I0Hw6wwVvHlc+PBfxH0+IvXOTV6yNK488n6m X-Received: by 2002:a17:907:c0f:: with SMTP id ga15mr19995713ejc.228.1625603661503; Tue, 06 Jul 2021 13:34:21 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k25sm6343895eds.77.2021.07.06.13.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 13:34:21 -0700 (PDT) Date: Tue, 6 Jul 2021 22:34:19 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Kishon Vijay Abraham I Cc: Jingoo Han , Joao Pinto , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Gustavo.Pimentel@synopsys.com, Mark Rutland , Santosh Shilimkar , Nishanth Menon , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 08/40] PCI: keystone: Cleanup MSI/legacy interrupt configuration and handling Message-ID: <20210706203419.GA213769@rocinante> References: <20180921102155.22839-1-kishon@ti.com> <20180921102155.22839-9-kishon@ti.com> <20210703210152.GA16176@rocinante> <56160f1d-ec91-3b99-312c-aef66eb1a7c2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56160f1d-ec91-3b99-312c-aef66eb1a7c2@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, [...] > > Would it be possible to resurrect this? Do you need any help? > > A lot of patches in this series should already be merged (after > splitting into smaller ones) > http://patchwork.ozlabs.org/project/linux-pci/list/?series=71185 > > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20190321095927.7058-1-kishon@ti.com/ Ah! Nice! [...] > Are there any other clean-ups you are looking into? Bjorn was looking recently at struct keystone_pcie and suggested that perhaps things such as for example the legacy_host_irqs member could be refactored - in this particular case it seems to only store a single item in the array, etc. And this series of patches I found is refactoring a lot of the elements of the driver and thus the struct keystone_pcie too in due process. I suppose, it would be just better to wait for you to complete all the work you have planned? What do you think? Krzysztof